CHIA-2219 Fix a plot ID calculation typo in test_unfinished_block_with_replaced_generator

[AmineKhaldi]

calculate_plot_id_pk takes a G1Element pool_public_key and calculate_plot_id_ph takes a bytes32 pool_contract_puzzle_hash.

It doesn't make sense to use the public key when it's None, and this typo went unnoticed because the runtime outcome for this input would end up being the same because of both functions' implementations:

chia-blockchain/chia/types/blockchain_format/proof_of_space.py

Lines 110 to 121 in 115cba1

	def calculate_plot_id_pk(
	pool_public_key: G1Element,
	plot_public_key: G1Element,
	) -> bytes32:
	return std_hash(bytes(pool_public_key) + bytes(plot_public_key))
	def calculate_plot_id_ph(
	pool_contract_puzzle_hash: bytes32,
	plot_public_key: G1Element,
	) -> bytes32:
	return std_hash(bytes(pool_contract_puzzle_hash) + bytes(plot_public_key))

[coveralls-official]

Pull Request Test Coverage Report for Build 12906288903

Details

• 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
• 22 unchanged lines in 4 files lost coverage.
• Overall coverage increased (+0.02%) to 91.532%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/_tests/core/full_node/test_full_node.py	1	3	33.33%

Files with Coverage Reduction	New Missed Lines	%
chia/wallet/util/wallet_sync_utils.py	1	86.14%
chia/server/node_discovery.py	2	81.5%
chia/wallet/wallet_node.py	8	87.74%
chia/timelord/timelord.py	11	78.52%

Totals
Change from base Build 12894248841:	0.02%
Covered Lines:	105339
Relevant Lines:	114909

---

💛 - Coveralls