Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name wallet protocol subscription messages consistently #19132

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

Rigidity
Copy link
Contributor

Makes the names of wallet protocol messages consistent with the rest of the code and the docs.

register_interest_in_coin => register_for_coin_updates
register_interest_in_puzzle_hash => register_for_ph_updates
respond_to_coin_update => respond_to_coin_updates
respond_to_ph_update => respond_to_ph_updates

@Rigidity Rigidity requested a review from a team as a code owner January 13, 2025 19:12
@Rigidity Rigidity added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog full_node labels Jan 13, 2025
@Rigidity Rigidity requested a review from arvidn January 13, 2025 19:13
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little bit scary given that we use runtime reflection to call functions with the same names as those classes. who knows what other names may be connected to these at run-time.

Copy link
Contributor

@richardkiss richardkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Github sure makes it hard to resolve conversations that are outdated.

@pmaslana pmaslana merged commit 8f484e6 into main Jan 14, 2025
362 checks passed
@pmaslana pmaslana deleted the consistent-wallet-protocol-naming branch January 14, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog full_node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants