Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes zeros #18475

Merged
merged 5 commits into from
Oct 22, 2024
Merged

bytes zeros #18475

merged 5 commits into from
Oct 22, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Aug 15, 2024

Use the newly added bytes*.zeros attributes. Each commit contains a separate grouping of patterns. Note that the b"0" case is actually changing behavior from each byte being a value of 48 to each byte being a value of 0. This case affects only test and simulation patterns where the ASCII value of 0 was presumably just an arbitrary value, likely intended to be actually 0.

I have actually been rebasing this and each commit corresponds to a particular regex used to replace the uses. Might be easier to quickly scan each commit separately since the patterns will be consistent then instead of all mixed together.

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 30, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 20, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Sep 20, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 21, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/full_node/full_node_api.py 0.0% lines 1011
chia/wallet/did_wallet/did_wallet.py 0.0% lines 533, 540
Total Missing Coverage
132 lines 3 lines 97%

Copy link

Pull Request Test Coverage Report for Build 11441279798

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 129 of 132 (97.73%) changed or added relevant lines in 51 files are covered.
  • 54 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 91.012%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node_api.py 0 1 0.0%
chia/wallet/did_wallet/did_wallet.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.63%
chia/daemon/client.py 1 74.1%
chia/full_node/full_node_api.py 1 82.36%
chia/rpc/rpc_server.py 1 87.87%
chia/wallet/wallet_node.py 1 88.94%
chia/timelord/timelord.py 2 78.65%
chia/wallet/wallet.py 2 97.94%
chia/server/server.py 4 82.43%
chia/_tests/core/util/test_lockfile.py 4 88.66%
chia/farmer/farmer.py 7 72.47%
Totals Coverage Status
Change from base Build 11408390114: -0.04%
Covered Lines: 102569
Relevant Lines: 112675

💛 - Coveralls

@altendky altendky marked this pull request as ready for review October 22, 2024 12:34
@altendky altendky requested a review from a team as a code owner October 22, 2024 12:34
@altendky altendky requested a review from Quexington October 22, 2024 12:34
@pmaslana pmaslana merged commit 3b6f547 into main Oct 22, 2024
360 of 361 checks passed
@pmaslana pmaslana deleted the bytes_zeros branch October 22, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants