You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the newly added bytes*.zeros attributes. Each commit contains a separate grouping of patterns. Note that the b"0" case is actually changing behavior from each byte being a value of 48 to each byte being a value of 0. This case affects only test and simulation patterns where the ASCII value of 0 was presumably just an arbitrary value, likely intended to be actually 0.
I have actually been rebasing this and each commit corresponds to a particular regex used to replace the uses. Might be easier to quickly scan each commit separately since the patterns will be consistent then instead of all mixed together.
altendky
added
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Exclude_Notes
Use this label if the changes in the PR should be excluded from the release notes
labels
Aug 15, 2024
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
ChangedRequired label for PR that categorizes merge commit message as "Changed" for changelogExclude_NotesUse this label if the changes in the PR should be excluded from the release notes
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the newly added
bytes*.zeros
attributes. Each commit contains a separate grouping of patterns. Note that theb"0"
case is actually changing behavior from each byte being a value of 48 to each byte being a value of 0. This case affects only test and simulation patterns where the ASCII value of0
was presumably just an arbitrary value, likely intended to be actually 0.I have actually been rebasing this and each commit corresponds to a particular regex used to replace the uses. Might be easier to quickly scan each commit separately since the patterns will be consistent then instead of all mixed together.
Current Behavior:
New Behavior:
Testing Notes:
Draft For: