Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-942 Use launcher_id as the primary key when updating (current) pool config. #18341

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

aqk
Copy link
Contributor

@aqk aqk commented Jul 19, 2024

Add an error diagnostic for the case where updating fails due to the supplied closure.

Purpose: Remove bug

Current Behavior: Can update incorrect pool entry when multiple entries share the same owner key

New Behavior: Only update the specified launcher_id

Testing Notes:

Add an error diagnostic for the case where updating fails due to the supplied closure.
@aqk aqk requested a review from a team as a code owner July 19, 2024 16:26
@aqk aqk added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 19, 2024
@aqk aqk changed the title Use launcher_id as the primary key when updating (current) pool config. CHIA-942 Use launcher_id as the primary key when updating (current) pool config. Jul 19, 2024
@Starttoaster Starttoaster merged commit 5462631 into main Jul 22, 2024
373 of 374 checks passed
@Starttoaster Starttoaster deleted the ak.bugfix-pool-config-update branch July 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants