Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHIA-982 Simplify Mempool's items_by_feerate #18340

Merged
merged 1 commit into from
Aug 1, 2024
Merged

CHIA-982 Simplify Mempool's items_by_feerate #18340

merged 1 commit into from
Aug 1, 2024

Conversation

AmineKhaldi
Copy link
Contributor

We're only fetching data here.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jul 19, 2024
@AmineKhaldi AmineKhaldi self-assigned this Jul 19, 2024
@AmineKhaldi AmineKhaldi force-pushed the simplify_mempool_items_by_feerate branch from 7745764 to 5c072f9 Compare July 24, 2024 10:52
@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 31, 2024 11:10
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner July 31, 2024 11:10
arvidn
arvidn reviewed Aug 1, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it mean to use the connection as a context manager?
Why is it safe to not do that here?

@AmineKhaldi
Copy link
Contributor Author

what does it mean to use the connection as a context manager? Why is it safe to not do that here?

A Connection object can be used as a context manager that automatically commits or rolls back open transactions when leaving the body of the context manager. If the body of the with statement finishes without exceptions, the transaction is committed. If this commit fails, or if the body of the with statement raises an uncaught exception, the transaction is rolled back.

We're only fetching data here.

@Starttoaster Starttoaster merged commit 92fdb58 into Chia-Network:main Aug 1, 2024
368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees

@AmineKhaldi AmineKhaldi

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmineKhaldi @arvidn @Starttoaster