Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangling reference to twine #18325

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Remove dangling reference to twine #18325

merged 2 commits into from
Jul 24, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jul 16, 2024

Remove the dangling reference to twine in the dev dependencies

@emlowe emlowe requested a review from a team as a code owner July 16, 2024 22:14
@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 16, 2024
@emlowe emlowe requested a review from altendky July 16, 2024 22:15
altendky
altendky previously approved these changes Jul 16, 2024
Copy link

Pull Request Test Coverage Report for Build 9964843999

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 83 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.799%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/download_data.py 1 83.58%
chia/_tests/util/test_priority_mutex.py 1 99.66%
chia/_tests/util/test_action_scope.py 1 99.01%
chia/wallet/wallet_node.py 1 89.1%
chia/_tests/util/full_sync.py 1 88.95%
chia/daemon/client.py 1 73.94%
chia/server/server.py 1 82.21%
chia/rpc/wallet_rpc_api.py 1 89.34%
chia/introducer/introducer.py 1 78.26%
chia/util/json_util.py 1 88.46%
Totals Coverage Status
Change from base Build 9974793679: -0.07%
Covered Lines: 101721
Relevant Lines: 111979

💛 - Coveralls

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 18, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 24, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky
Copy link
Contributor

checks are being added for this in #18357

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Starttoaster Starttoaster merged commit 628b9c3 into main Jul 24, 2024
373 checks passed
@Starttoaster Starttoaster deleted the EL.fix-twine-error branch July 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants