Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-907 Augment uncurry_puzzle to accept both types of programs #18286

Merged

Conversation

AmineKhaldi
Copy link
Contributor

This allows us to use serialized programs without the need to convert them into programs.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jul 10, 2024
@AmineKhaldi AmineKhaldi self-assigned this Jul 10, 2024
@AmineKhaldi AmineKhaldi changed the title CHIA-907 Augment uncurry_puzzle to accept both types of puzzles CHIA-907 Augment uncurry_puzzle to accept both types of programs Jul 10, 2024
Copy link

Pull Request Test Coverage Report for Build 9872983642

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 29 (100.0%) changed or added relevant lines in 14 files are covered.
  • 69 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.04%) to 90.981%

Files with Coverage Reduction New Missed Lines %
chia/data_layer/download_data.py 1 83.58%
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/_tests/util/test_priority_mutex.py 1 99.66%
chia/rpc/rpc_server.py 1 88.7%
chia/_tests/util/test_action_scope.py 1 99.01%
chia/_tests/core/util/test_lockfile.py 1 89.47%
chia/timelord/timelord_launcher.py 1 70.07%
chia/_tests/util/full_sync.py 1 88.95%
chia/daemon/client.py 1 73.94%
chia/rpc/wallet_rpc_api.py 1 89.3%
Totals Coverage Status
Change from base Build 9874787143: -0.04%
Covered Lines: 101433
Relevant Lines: 111442

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 17, 2024 11:10
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner July 17, 2024 11:10
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Jul 17, 2024
This allows us to use serialized programs without the need to convert them into programs.
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 17, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't look right. The uncurry() member functions return different types.

chia/wallet/uncurried_puzzle.py Show resolved Hide resolved
@AmineKhaldi AmineKhaldi requested a review from arvidn July 30, 2024 11:44
@Starttoaster Starttoaster merged commit c4026f9 into Chia-Network:main Aug 1, 2024
368 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants