remove special case logic for soft-fork 3 activation

[arvidn]

Purpose:

Apply the new rules to the entire chain, to simplify our code.

Current Behavior:

Softfork-3 activates at height 4510000

New Behavior:

Softfork-3 activates at height 0

Test

here

Main currently runs 6391 tests, with this patch we run 5227 tests (saving 1164 tests)

[github-actions]

File	Coverage	Missing Lines
tests/core/mempool/test_mempool.py	0.0%	lines 2593

Total	Missing	Coverage
3 lines	Unknown	66%

[arvidn]

the missing test coverage is from a benchmark, which we don't instrument

[aqk]

What do you think about leaving the enum entry for SOFT_FORK3 at this line?

https://github.com/Chia-Network/chia-blockchain/pull/16819/files#diff-e52e4ddd58b7ef887ab03c04116e676f6280b824ab7469d5d3080e5cba4f2128L156

I know it's in git history; I just wonder if it's worth keeping a list of all the soft-forks somewhere visible.

Ah, I see. There's really no need.

[aqk]

I wish I could reply to comments on this main page, since we're forced to use comments here for comments that won't block the PR.

[arvidn]

I don't really expect it to be very likely to restore the soft-fork3 tests. but worst case we can always:

git log -p -- chia/consensus/default_constants.py