updating metadata with multiple uris fix #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paninaro
reviewed
May 16, 2022
| key = metadata_entry[0] | ||
| if key == b"u": | ||
| new_metadata.append((b"u", [condition.rest().rest().first().atom] + list(metadata_entry[1:]))) | ||
| else: |
There was a problem hiding this comment.
Is it reasonable to assume that h is the only other metadata key? I thought we were going to support keys like l, lh, m and mh (or similar), but maybe those can't be updated at this point.
There was a problem hiding this comment.
yes, only made a fix for current codebase, this will need to be expanded as part of the "support updating metadata url and license" task
ytx1991
reviewed
May 16, 2022
| for metadata_entry in metadata_list: | ||
| key = metadata_entry[0] | ||
| if key == b"u": | ||
| new_metadata.append((b"u", [condition.rest().rest().first().atom] + list(metadata_entry[1:]))) |
There was a problem hiding this comment.
Why list(metadata_entry[1:]) here? Shouldn't be metadata_entry[1]? Since it's a list of uris
There was a problem hiding this comment.
metadata_entry looks something like this when deserialized: (b'u', 'url1', 'url2' ... ) not sure why .as_python deserializes it like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.