Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OBJECT_ADDITIONAL_PROPERTIES #9

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Fix OBJECT_ADDITIONAL_PROPERTIES #9

merged 1 commit into from
Jan 13, 2022

Conversation

ChenglongLiu
Copy link
Owner

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@ChenglongLiu ChenglongLiu merged commit 681eb8a into cdn-swagger-2021-06-01-fix Jan 13, 2022
ChenglongLiu pushed a commit that referenced this pull request Jan 19, 2022
@niteshvijay1995 @anujtoshniwal
@abhijitkaranjkar89 @kavskalyan @vivek-microsoft @vivek67 @ajparule @amisi01 @pjohari-ms
[Hub Generated] Review request for Microsoft.DocumentDB to add versio…
5405df1 
…n preview/2021-10-15-preview (Azure#16211)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* Antoshni cosmos db 2021 10 15 preview cek management (#1)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* ClientEncryptionKey management API changes

* Address semantics validation errors

* Fix representation of wrappedDek

* fix Swagger prettier formatting check

* minor edits to address comments"

* fix LintDiff error

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* remove CreateUpdateOptions as they arent applicable for CEK

* fix Model validation check

Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com>
Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com>

* mongo rbac cherry-pick (#5)

* mongo rbac cherry-pick

* Removing entry for 07 preview

Co-authored-by: kavskalyan <kakhandr@microsoft.com>

* Revert "mongo rbac cherry-pick (#5)" (#7)

This reverts commit 8392017.

* preview swagger for managed cassandra (#8)

* preview swagger for managed cassandra

* add cassandraAuditLoggingEnabled property

* change property name in CommandPostBody

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* fix validation, remove connectivity (#11)

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Add data transfer job api (#2)

* Adds base for updating Microsoft.DocumentDB from version preview/2021-07-01-preview to version 2021-10-15-preview

* Updates readme

* Updates API version in new specs and examples

* Add DataTransfer job apis

* Fix api version

* Rename connection to endpointUrl

* Rename connection to endpointUrl

* Add dataTransferService in readme.md

* Fix keys

* Fix checks

* Add worker count

* Fix worker count

* MaterializedViewsBuilder (#12)

* Adding LatestRestorableTimestamp support for MongoDB collections. (#9)

* Adding LatestRestorableTimestamp support for MongoDB

* Fixing api version for examples.

* Mongo RBAC Swagger Changes (#10)

* mongo rbac cherry-pick

* Removing entry for 07 preview

* Fixing swagger issues

* Fixing swagger error for param

* Fixing misplaced Description

* Fixing model validation issues

* Json pretty formatting

* Fixing more model validation issues

* Fixing type issue

* Add password field for userdef request

* Fixing URL param

* Fixing URL param issue

Co-authored-by: kavskalyan <kakhandr@microsoft.com>

* TotalThroughput limit 10-15 preview API changes (#6)

* add backupStorageCustomerKeyUri and fix response status code (Azure#13)

* fix validation, remove connectivity

* add backupStorageCustomerKeyUri property

* fix response status code

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Prettier fix

* Fix Avocado check

* Fix operationId

* Fix operationId

* Fix breaking change

* Fix breaking change (managedCassandra invokeCommand)

* Fix breaking change

* Fix status code in example

* Fix review comment

* Use v3 version for resource-management

* Fix client encryption review comments

* update location header in example (Azure#15)

Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>

* Prettier fix

* update header in response

* formating json

Co-authored-by: anujtoshniwal <62551957+anujtoshniwal@users.noreply.github.com>
Co-authored-by: Anuj Toshniwal <antoshni@microsoft.com>
Co-authored-by: Abhijit Karanjkar <abhijitkaranjkar@gmail.com>
Co-authored-by: kavskalyan <kakhandr@microsoft.com>
Co-authored-by: vivek-microsoft <32766101+vivek-microsoft@users.noreply.github.com>
Co-authored-by: Vivek Sundararajan <s.vivek.rajan@gmail.com>
Co-authored-by: Ajay Parulekar <79739098+ajparule@users.noreply.github.com>
Co-authored-by: Amit Singh <31076927+amisi01@users.noreply.github.com>
Co-authored-by: pjohari-ms <84465928+pjohari-ms@users.noreply.github.com>
@ChenglongLiu ChenglongLiu deleted the chenglong/fixbug2 branch January 19, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinadell sinadell Awaiting requested review from sinadell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChenglongLiu