This repository has been archived by the owner on Jun 11, 2022. It is now read-only.
Re-enable parallax animation when switching page unanimated. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your Pull Request, will have a look at it asap and give it a spin to test it. |
|
Have you had the time to test this yet? |
|
@Cheesebaron have you forgotten about this? |
|
@BitKaitsu had totally forgotten about this. Will review today 👍 |
Cheesebaron
force-pushed
the
bugfix/keep_parallax_enabled
branch
from
0635353
to
17d3d85
Compare
Cheesebaron
approved these changes
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again. I noticed I inadvertently caused a minor bug that causes the parallax animation to not work when it should.
When opening a view using the pager and switching tabs by scrolling the content, the tab scroll view does not scroll along and stays in the same position. Touching the tabs re-enables the correct behaviour. This might only happen after calling SwitchPage for the view with the animated flag set to false.
I changed the condition for enabling/disabling parallax back to
!animated, which it was before my previous changes. I thought the!wasn't intentional which made me remove it. This commit restores it.