Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter #22

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Add linter #22

merged 7 commits into from
Jan 23, 2025

Conversation

juliangruber
Copy link
Member

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025 •
edited
Loading

Deploying spark-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 42f19c3
Status: ✅  Deploy successful!
Preview URL: https://9ed7e219.spark-dashboard.pages.dev
Branch Preview URL: https://add-lint.spark-dashboard.pages.dev

View logs

@juliangruber juliangruber changed the title Add JS linter Add linter Jan 21, 2025
@juliangruber
Copy link
Member Author

I switched from standard to prettier as I couldn't get eslint markdown listing to work with the YAML frontmatter we use

pyropy
pyropy approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

bajtos
bajtos reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love adopting a linter that's more opinionated about formatting.

At the same time, we haven't agreed that Prettier is the tool we want to use.

I am a bit reluctant to use different linters in different repositories.

Let's discuss.

.prettierignore Show resolved Hide resolved
src/index.md Outdated Show resolved Hide resolved
@juliangruber juliangruber requested a review from bajtos January 22, 2025 08:08
bajtos
bajtos approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@juliangruber juliangruber merged commit 0cd531d into main Jan 23, 2025
3 checks passed
@juliangruber juliangruber deleted the add/lint branch January 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@pyropy pyropy pyropy approved these changes

@NikolasHaimerl NikolasHaimerl Awaiting requested review from NikolasHaimerl NikolasHaimerl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliangruber @bajtos @pyropy