Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix don't report unactionable w3name request errors to Sentry #652

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix don't report unactionable w3name request errors to Sentry #652

merged 3 commits into from
Dec 18, 2024

Conversation

juliangruber
Copy link
Member

pyropy
pyropy approved these changes Dec 17, 2024
View reviewed changes
Copy link

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I wonder if we'd have any benefits of keeping metrics on how often are these errors happening?

@bajtos
Copy link
Member

bajtos commented Dec 17, 2024

Changes look good! I wonder if we'd have any benefits of keeping metrics on how often are these errors happening?

That's what I was thinking too!

pyropy
pyropy reviewed Dec 18, 2024
View reviewed changes
Copy link

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit:

@juliangruber juliangruber enabled auto-merge (squash) December 18, 2024 12:28
@juliangruber
Copy link
Member Author

I hadn't yet set up commit signing on this machine, all future commits will be signed

@juliangruber
fix don't report unactionable w3name request errors to Sentry
c9acddc 
Signed-off-by: Julian Gruber <julian@juliangruber.com>
@juliangruber
add report errors to influxdb
71eb89e 
Signed-off-by: Julian Gruber <julian@juliangruber.com>
@juliangruber juliangruber force-pushed the fix/silence-w3name-sentry branch from 449fe8d to 71eb89e Compare December 18, 2024 12:37
@juliangruber juliangruber merged commit 6e626d2 into main Dec 18, 2024
18 checks passed
@juliangruber juliangruber deleted the fix/silence-w3name-sentry branch December 18, 2024 12:40
@juliangruber
Copy link
Member Author

Also added to Grafana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyropy pyropy pyropy approved these changes

@bajtos bajtos Awaiting requested review from bajtos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliangruber @bajtos @pyropy