Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redundant exit message #551

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix redundant exit message #551

merged 1 commit into from
Jul 24, 2024

Conversation

juliangruber
Copy link
Member

Remove the exit event handler which would create duplicate activity events on a crash.

Remove the `exit` event handler which would create duplicate
activity events on a crash.
@juliangruber juliangruber requested a review from bajtos July 24, 2024 10:39
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, your change is removing redundant activity log entries printed when the Zinnia process exits either with a non-zero exit code or via a signal. After your change, only one activity should be logged. That's a great improvement! 👏🏻

@juliangruber juliangruber merged commit dad75ed into main Jul 24, 2024
4 of 18 checks passed
@juliangruber juliangruber deleted the update/exit-handling branch July 24, 2024 13:10
@juliangruber
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants