Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix don't report expected voyager crashes to sentry #421

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

juliangruber
Copy link
Member

No description provided.

@juliangruber juliangruber requested a review from bajtos April 22, 2024 11:30
@juliangruber juliangruber marked this pull request as ready for review April 22, 2024 11:40
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

We should revert this change after we implement CheckerNetwork/zinnia#518 and improve Voyager to handle uncaught errors from Saturn.

@juliangruber juliangruber merged commit 10247a1 into main Apr 22, 2024
18 checks passed
@juliangruber juliangruber deleted the fix/voyager-error-sentry branch April 22, 2024 14:33
@juliangruber
Copy link
Member Author

Copy link

sentry-io bot commented Apr 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Spark crashed with exit code 3221225773 catchChildProcessExit(zinnia) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants