Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump undici from 5.28.2 to 6.0.1 #290

Closed
wants to merge 7 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 6, 2023

Bumps undici from 5.28.2 to 6.0.1.

Release notes

Sourced from undici's releases.

v6.0.1

What's Changed

Full Changelog: nodejs/undici@v6.0.0...v6.0.1

v6.0.0

What's Changed

Full Changelog: nodejs/undici@v5.28.2...v6.0.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 6, 2023
@dependabot dependabot bot requested review from bajtos and juliangruber December 6, 2023 08:45
@github-actions github-actions bot enabled auto-merge (squash) December 6, 2023 08:46
Copy link

socket-security bot commented Dec 6, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
undici 5.28.2...6.0.1 None +0/-0 1.18 MB ronag

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/undici-6.0.1 branch 2 times, most recently from 4b38d19 to 4389ed7 Compare December 7, 2023 11:31
Bumps [undici](https://github.com/nodejs/undici) from 5.28.2 to 6.0.1.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.2...v6.0.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/undici-6.0.1 branch from 4389ed7 to 3fae558 Compare December 7, 2023 11:34
@juliangruber juliangruber disabled auto-merge December 7, 2023 15:09
@juliangruber
Copy link
Member

cc @bajtos are you ok with removing deprecated node 16 support?

@bajtos
Copy link
Member

bajtos commented Dec 7, 2023

cc @bajtos are you ok with removing deprecated node 16 support?

Sure, why not?

  • I believe Station Desktop runs on an Electron version that ships Node.js 18.x or maybe even newer, so we should be good here.
  • I recently changed Station Core docker file to use Node 20.x LTS as the base, all is good here.

Maybe we should update engines fields in Station Core's package.json?

@juliangruber
Copy link
Member

To me it's a question of principle: I drop support for all EOL nodejs versions, without consideration for who might still be using them. This I believe helps maintain a safer and healthier ecosystem. But, I didn't know whether you thought about it the same way, so I wanted to ask.

Cool, will drop support then 👍

I can update .engines to be on the safe side

@juliangruber juliangruber enabled auto-merge (squash) December 8, 2023 10:58
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 21, 2023

A newer version of undici exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@bajtos
Copy link
Member

bajtos commented Apr 25, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 25, 2024

Superseded by #427.

@dependabot dependabot bot closed this Apr 25, 2024
auto-merge was automatically disabled April 25, 2024 12:15

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/undici-6.0.1 branch April 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants