Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zinnia: fix reporting AbortErrors to Sentry #679

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

juliangruber
Copy link
Member

Fixes https://space-meridian.sentry.io/issues/5857510005/?query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&sort=freq&statsPeriod=14d&stream_index=1 and more.

Before this change, an abort error will always be reported to Sentry. Situations that trigger an abort:

  • Module has been inactive (I have added error handling specifically for this here)
  • Any other error happened (this is already being reported to Sentry, no need to report the resulting abort error)
  • Restarting Zinnia after updating source files (not an error)

Looking at Sentry, and especially the view of all issues sorted by number of events, this is the biggest offender that is still happening.

@juliangruber juliangruber requested a review from bajtos February 10, 2025 17:11
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this issue!

@juliangruber juliangruber merged commit 85476b6 into main Feb 10, 2025
18 checks passed
@juliangruber juliangruber deleted the fix/sentry-ignore-abort-errors branch February 10, 2025 17:32
@juliangruber
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants