chore: mini refactorings and dead code removal #5512
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does a few things:
ConcurrentMap.hpp
(2x: util/ and common/)util/Clamp.hpp
(uses C++ 17'sstd::clamp
)util/SplitCommand.{c,h}pp
(usesQProcess::splitCommand
, 5.15+)util/Overloaded.hpp
(we only useutil/Variant.hpp
)util/PersistSignalVector.hpp
(unused)util/PostToThread.hpp
chatterino::_helpers_internal
tochatterino::helpers::detail
DisplayBadge.hpp
<algorithm>
include inExponentialBackoff.hpp
step_
inExponentialBackoff.hpp
(clang-tidy complained thatstep_
was uninitialized (?))IWYU paragma: export
toPubSubMessages.hpp
(sadly clangd doesn't seem to pick this up in files using the header)LayoutCreator
to use concepts (should make it a bit easier to read)T2
withU
-U
being the newly created/returned typeaddSpacing
to be called on aQLayout
(widgets don't support that)addItem
(a bit)