Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to interpret logger channel names as lowercase #4848

Merged
merged 8 commits into from
Oct 1, 2023
Merged

Fix to interpret logger channel names as lowercase #4848

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f193009
Fix to interpret logger channel names as lowercase
GongBingWong Sep 30, 2023
319bbe7
Add changelog entry
GongBingWong Sep 30, 2023
6859cf6
Update CHANGELOG.md
GongBingWong Sep 30, 2023
1e27ca1
Update src/controllers/logging/ChannelLog.cpp
GongBingWong Sep 30, 2023
b73ce00
Return lowercase without temporary variable
GongBingWong Sep 30, 2023
6ba35a7
Merge branch 'master' into master
GongBingWong Sep 30, 2023
adbb52d
nit: Link to the PR instead of the Issue in the changelog entry
pajlada Oct 1, 2023
7112865
Merge remote-tracking branch 'origin/master' into GongBingWong/master
pajlada Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Minor: Migrate to the new Get Channel Followers Helix endpoint, fixing follower count not showing up in usercards. (#4809)
- Minor: The account switcher is now styled to match your theme. (#4817)
- Minor: Add an invisible resize handle to the bottom of frameless user info popups and reply thread popups. (#4795)
- Bugfix: Fixed capitalized channel names in log inclusion list not being logged. (#4835)
- Bugfix: Trimmed custom streamlink paths on all platforms making sure you don't accidentally add spaces at the beginning or end of its path. (#4834)
- Bugfix: Fixed a performance issue when displaying replies to certain messages. (#4807)
- Bugfix: Fixed a data race when disconnecting from Twitch PubSub. (#4771)
Expand Down
3 changes: 2 additions & 1 deletion src/controllers/logging/ChannelLog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ ChannelLog::ChannelLog(QString channelName)

QString ChannelLog::channelName() const
{
return this->channelName_;
QString lowercaseChannelName_ = this->channelName_.toLower();
return lowercaseChannelName_;
GongBingWong marked this conversation as resolved.
Show resolved Hide resolved
pajlada marked this conversation as resolved.
Show resolved Hide resolved
}

QString ChannelLog::toString() const
Expand Down