Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle to Hype Chats #4715

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jul 2, 2023

Description

This PR adds a subtitle to Hype Chats. It contains the level, the duration, and the amount of money spent. The money is currently formatted according to the system locale.

Example:
chatterino_2023-07-02_17-52-03

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/IrcMessageHandler.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected.
image
Tested along-side the basic filter (flags.elevated_message && !(message.content contains "hype chat")) to hide this new feature if the user wanted to. (could be a better filter)

@pajlada pajlada enabled auto-merge July 30, 2023 12:55
@pajlada pajlada added this pull request to the merge queue Jul 30, 2023
Merged via the queue into Chatterino:master with commit 703847c Jul 30, 2023
@Nerixyz Nerixyz deleted the feat/more-hype-chat branch July 30, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants