Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust plugin documentation to match implementation #4540

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Adjust plugin documentation to match implementation #4540

merged 1 commit into from
Apr 14, 2023

Conversation

4rneee
Copy link
Contributor

@4rneee 4rneee commented Apr 14, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The documentation for plugins contained the following errors which have now been fixed:

  • The authors field in info.json was a string but actually should be an array of strings
  • The CommandContext field channel_name was wrongly referred to as channelName

@Mm2PL Mm2PL self-requested a review April 14, 2023 17:44
@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 14, 2023

Yeah i must have forgotten to update these when changing the code :D

@Felanbird Felanbird enabled auto-merge (squash) April 14, 2023 17:47
@Felanbird Felanbird merged commit cd6e1c0 into Chatterino:master Apr 14, 2023
@4rneee 4rneee deleted the plugin-documentation branch June 4, 2023 06:32
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felanbird Felanbird Felanbird approved these changes

@Mm2PL Mm2PL Mm2PL approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4rneee @Mm2PL @pajlada @Felanbird