Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RangeReplaceableCollection protocol implementation for 3.6 version #4942

Closed
wants to merge 2 commits into from

Conversation

flaviosuardi
Copy link

@flaviosuardi flaviosuardi commented Oct 5, 2022

Issue Link πŸ”—

#4873

Goals ⚽

I fix problem related to RangeReplaceableCollection protocol implemented on ChartDataSet adding replaceSubrange method for 3.6 version.

Implementation Details 🚧

Testing Details πŸ”

I just rebuild project and no build errors occur on Xcode 14.0.

@flaviosuardi flaviosuardi changed the title Replace subrange Fix RangeReplaceableCollection protocol implementation for 3.6 version Oct 5, 2022
@JGVB
Copy link

JGVB commented Oct 14, 2022

Please merge this so charts is useable on xcode 14.

@lucasiturbide
Copy link

lucasiturbide commented Oct 14, 2022

the base branch is outdated in tiknil repository, master branch in danielgindi is actually already fixed.

@KaranVakharia789
Copy link

I fixed it.
please check below link:
https://stackoverflow.com/questions/74010925/charts-not-compile-on-xcode-14

@liuxuan30
Copy link
Member

as @lucasiturbide said, we cannot merge this onto master

@liuxuan30 liuxuan30 closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants