Add gradient bars for BarChart #3533
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.0.0 #3533 +/- ##
==========================================
- Coverage 31.49% 31.27% -0.22%
==========================================
Files 112 112
Lines 10050 10127 +77
==========================================
+ Hits 3165 3167 +2
- Misses 6885 6960 +75
Continue to review full report at Codecov.
|
Source/Charts/Utils/ChartUtils.swift
Outdated
| return CGPoint(x: CGFloat.infinity, y: CGFloat.infinity) | ||
| } | ||
|
|
||
| var isIntinite: Bool { |
There was a problem hiding this comment.
fixed and rebased on branch/4.0.0
larryonoff
force-pushed
the
bar-chart-gradient
branch
from
5b6af91 to
7044b10
Compare
larryonoff
force-pushed
the
bar-chart-gradient
branch
from
7044b10 to
ac8c456
Compare
|
I need this functionality in the bar charts. Can you please add this in master branch. |
|
it takes time to review and merge. I'm sorry we are short handed, so either you take the code and merge on your side, or just wait. After all, it's open source. |
| let set = BarChartDataSet(values: yVals, label: "The year 2017") | ||
| set.drawValuesEnabled = false | ||
|
|
||
| setup(set) |
There was a problem hiding this comment.
I think setup(set) can go out of this if-else condition.
|
Hello there, I would appreciate this feature being introduced in the Framework. Is there any way I can help with the process? (e.g.: Continue developing the feature and fix merge issues, or maybe with CC and tests) |
|
Nobody from the team responds on this PR for a long time. So I still use Charts from my branch |
|
sorry. but really busy for the team. I just saw my inbox there is another #3225 about bar gradient. would guys work together to see which is better? |
|
I'm not sure, but this PR can be based on #3225. This was long time ago. |
|
is it possible that you guys can work together to merge into one great pull request? |
larryonoff
force-pushed
the
bar-chart-gradient
branch
from
ac8c456 to
33d8e48
Compare
|
Hi! Could you be nice to process this pull request? Cheers |
|
I hope so, but we need to decide which to merge, this or #3225. |
|
I think it's probably better to go with one and keep improving it than delay the decision. These 2 PRs have been ready for over a year now, and it would be great to get this functionality😊🙏 |
|
if that is the case, than probably we need to take a look at both PR and decide the better one |
|
@liuxuan30 Any idea which PR will be getting merged in? This one or #3225? Would love to have one of them merged in soon is possible. Seems like they both have passed all the checks but this one doesn’t have any pending changes. Thanks for your help! |
|
I will see if I can pull it off this or next week. |
|
first thing, this is targeted to 4.0 branch? @jjatie do you remember why we add the two similar PRs to 4.0? is it possible to rebased on master? |
|
I believe that I rebased it properly #4411 |
|
so we could close this and move to #4411? |
|
@liuxuan30 lets close current PR |
This PR adds functionality to draw gradient bars with
BarChartDataSet