Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONCommunicator instantiates GsonBuilder, ZonedDateTime adapter and Gson for each serialization/deserialization #168

Closed
dimaa6 opened this issue Jan 11, 2022 · 0 comments · Fixed by #169
Closed

JSONCommunicator instantiates GsonBuilder, ZonedDateTime adapter and Gson for each serialization/deserialization #168

dimaa6 opened this issue Jan 11, 2022 · 0 comments · Fixed by #169

Comments

@dimaa6
Copy link

dimaa6 commented Jan 11, 2022

This is performance penalty and additional load on garbage collector. Gson is thread-safe, adapters don't involve anything related to synchronization. I will provide pull request which fixes this issue soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made Gson static to avoid creating it for each (de)serialization requ… dimaa6/Java-OCA-OCPP
1 participant
@dimaa6