Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

data-react-helmet breaks opensearch #162

Closed
Chalarangelo opened this issue Sep 6, 2020 · 1 comment · Fixed by #163
Closed

data-react-helmet breaks opensearch #162

Chalarangelo opened this issue Sep 6, 2020 · 1 comment · Fixed by #163
Assignees
@Chalarangelo
Labels
bug Something isn't working
Milestone
2020 Sprint #12

Comments

@Chalarangelo
Copy link
Owner

Chalarangelo commented Sep 6, 2020 •
edited
Loading

data-react-helmet breaks opensearch (and probably other things). Let's get rid of it wherever we can, if we can use a workaround such as onPreRenderHTML.
@Chalarangelo Chalarangelo added the bug Something isn't working label Sep 6, 2020
@Chalarangelo Chalarangelo added this to the 2020 Sprint #12 milestone Sep 6, 2020
@Chalarangelo Chalarangelo self-assigned this Sep 6, 2020
@Chalarangelo
Copy link
Owner Author

Related: nfl/react-helmet#79

Chalarangelo added a commit that referenced this issue Sep 6, 2020
@Chalarangelo
Fix XMLs injected with data-react-helmet
444988b 
Fixes #162
@Chalarangelo Chalarangelo mentioned this issue Sep 6, 2020
Merged
Chalarangelo added a commit that referenced this issue Sep 6, 2020
@Chalarangelo
Merge pull request #163 from 30-seconds/static-xmls
a3947aa 
Fix XMLs injected with data-react-helmet

Fixes #162
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Chalarangelo Chalarangelo

Labels
bug Something isn't working
Projects
None yet
Milestone
2020 Sprint #12
Development

Successfully merging a pull request may close this issue.

Fix XMLs injected with data-react-helmet Chalarangelo/30-seconds-web
1 participant
@Chalarangelo