Lootbox namespace change and error checks #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
juans-chainsafe,
kalambet,
kantagara,
oleksandrchainsafe,
robGG1997 and
RyRy79261
2 tasks
2 tasks
kantagara
approved these changes
Nov 2, 2023
robGG1997
suggested changes
Nov 2, 2023
Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Scenes/Login.cs
Show resolved
Hide resolved
RyRy79261
approved these changes
Nov 2, 2023
robGG1997
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Lootbox namespace change * Auto-duplicate Packages Samples * Update Login.cs * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Lootbox namespace change * Auto-duplicate Packages Samples * Update Login.cs * Auto-duplicate Packages Samples --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We need to start preparing lootboxes for OPM submission, the scope of this task is a namespace change and error checks #660
Updates:
To Test:
Import the lootbox package and run it in the editor. You don't need to use the login scene currently as the launcher script initializes from a local rpc node. Just update your web3config class variables in web3.unity\src\UnitySampleProject\Assets\Samples\web3.unity SDK Lootboxes\1.0.0\Chainlink Lootbox Sample\Scripts\ChainlinkLootboxSampleLauncher.cs to match your local node config.
Expected Behavior:
No errors on import due to the namespace changes.
If you're testing with a local RPC node, everything should work as intended.