Goerli Exception #693
Merged
Goerli Exception #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple check on the sample scene that throws an exception informing the user that they need to be on the goerli chain to see the examples functioning.
auto-assign
bot
requested review from
juans-chainsafe,
kalambet,
kantagara,
oleksandrchainsafe,
robGG1997 and
RyRy79261
kantagara
reviewed
Oct 31, 2023
Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Scenes/SampleMain/GoerliCheck.cs
Outdated
Show resolved
Hide resolved
kantagara
approved these changes
Oct 31, 2023
Web3 exception
juans-chainsafe
approved these changes
Oct 31, 2023
RyRy79261
approved these changes
Oct 31, 2023
robGG1997
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Goerli check A simple check on the sample scene that throws an exception informing the user that they need to be on the goerli chain to see the examples functioning. * Auto-duplicate Package Samples * Web3 exception Web3 exception * Auto-duplicate Package Samples --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Goerli check A simple check on the sample scene that throws an exception informing the user that they need to be on the goerli chain to see the examples functioning. * Auto-duplicate Package Samples * Web3 exception Web3 exception * Auto-duplicate Package Samples --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple check on the sample scene that throws an exception informing the user that they need to be on the goerli chain to see the examples functioning. Closes #649
I've placed the script on an object in the root of the sample main scenes object hierarchy. I didn't want to put the check on the sample scripts or in the behavior as we would just be creating more code for the user to edit come development time.
To test, simply login to the samples main area on a chain that isn't goerli and you should see an error.