Sample Updates #690
Merged
Sample Updates #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added contract call and private key sign/send to the UnsortedSample.cs file. Removed some magic strings and changed them to input parameters in UnsortedSample.cs. Updated tests.
auto-assign
bot
requested review from
juans-chainsafe,
kalambet,
kantagara,
oleksandrchainsafe,
robGG1997 and
RyRy79261
kantagara
reviewed
Oct 30, 2023
| @@ -8,6 +8,10 @@ public class ContractSendBehaviour : SampleBehaviour | |||
| public string method = "addTotal"; | |||
| public string abi = "[ { \"inputs\": [ { \"internalType\": \"uint8\", \"name\": \"_myArg\", \"type\": \"uint8\" } ], \"name\": \"addTotal\", \"outputs\": [], \"stateMutability\": \"nonpayable\", \"type\": \"function\" }, { \"inputs\": [], \"name\": \"myTotal\", \"outputs\": [ { \"internalType\": \"uint256\", \"name\": \"\", \"type\": \"uint256\" } ], \"stateMutability\": \"view\", \"type\": \"function\" } ]"; | |||
| public string contractAddress = "0x7286Cf0F6E80014ea75Dbc25F545A3be90F4904F"; | |||
| public object[] args = | |||
| { | |||
| 1 | |||
There was a problem hiding this comment.
What does that number 1 actually represent?
There was a problem hiding this comment.
The amount to increase the state variable by like so:
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;
contract AddTotal {
uint256 public myTotal = 0;
function addTotal(uint8 _myArg) public {
myTotal = myTotal + _myArg;
}
}
There was a problem hiding this comment.
I should probably refactor the object so it's initialized from a public integer so it's not sitting there as a magic number too. BRB.
kantagara
reviewed
Oct 31, 2023
juans-chainsafe
requested changes
Oct 31, 2023
|
@juans-chainsafe Theres a fix in @sneakzttv latest goerli PR that is approved that should resolve that issue |
|
should work now @juans-chainsafe |
juans-chainsafe
approved these changes
Oct 31, 2023
robGG1997
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Sample Updates Added contract call and private key sign/send to the UnsortedSample.cs file. Removed some magic strings and changed them to input parameters in UnsortedSample.cs. Updated tests. * Auto-duplicate Package Samples * Update ContractSendBehaviour.cs * Auto-duplicate Package Samples * Test case Updated test case to use a constant instead of a magic number --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Sample Updates Added contract call and private key sign/send to the UnsortedSample.cs file. Removed some magic strings and changed them to input parameters in UnsortedSample.cs. Updated tests. * Auto-duplicate Package Samples * Update ContractSendBehaviour.cs * Auto-duplicate Package Samples * Test case Updated test case to use a constant instead of a magic number --------- Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contract call and private key sign/send to the UnsortedSample.cs file for ECDSA later.
Removed some magic strings and changed them to input parameters in UnsortedSample.cs.
Updated tests.