-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstring for Web3 folder in Chainsafe.Gaming #674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
juans-chainsafe,
kalambet and
robGG1997
October 19, 2023 15:41
robGG1997
suggested changes
Oct 20, 2023
robGG1997
previously requested changes
Oct 20, 2023
kalambet
requested changes
Oct 23, 2023
src/ChainSafe.Gaming/Web3/Core/Analytics/NoOpAnalyticsClientExtensions.cs
Show resolved
Hide resolved
src/ChainSafe.Gaming/Web3/Core/Build/Web3ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
src/ChainSafe.Gaming/Web3/Core/Build/Web3ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
sneakzttv
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay comments
kalambet
approved these changes
Oct 25, 2023
kalambet
dismissed
robGG1997’s stale review
October 25, 2023 13:26
It is a GitHub bug. Issue is already resolved.
robGG1997
pushed a commit
that referenced
this pull request
Nov 3, 2023
* Added XML comments for Web3 folder * Added XML comments for Web3 folder (2) * Added XML comments for Web3 folder (3) * Fixed ChainRegistryProvider constructor * Removed IInitializableWeb3 * Fixed Docstring for Web3 folder * retrigger checks --------- Co-authored-by: Peter Kalambet <peter@kalambet.dev>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Added XML comments for Web3 folder * Added XML comments for Web3 folder (2) * Added XML comments for Web3 folder (3) * Fixed ChainRegistryProvider constructor * Removed IInitializableWeb3 * Fixed Docstring for Web3 folder * retrigger checks --------- Co-authored-by: Peter Kalambet <peter@kalambet.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus some small refactoring
Some of the stuff was generated using ChatGPT while the other part was written by me. So if you find something is not descriptive enough, tell me.