Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return correct property gindex for ContainerNodeStructType #328

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: return correct property gindex for ContainerNodeStructType #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/ssz/src/type/containerNodeStruct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ export class ContainerNodeStructType<Fields extends Record<string, Type<unknown>

// ContainerNodeStructType can only parse proofs that contain all the data.
// TODO: Support converting a partial tree to a partial value
getPropertyGindex(): null {
return null;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I dealt with this code, but what about the comment?

ContainerNodeStructType can only parse proofs that contain all the data

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comment. I can put in a more effort to make the UX a bit nicer here


// Post process tree to convert regular BranchNode to BranchNodeStruct
// TODO: Optimize conversions
Expand Down