Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

Closes #23 - switch to little edian #25

Merged
merged 10 commits into from
Jan 24, 2019
Merged

Closes #23 - switch to little edian #25

merged 10 commits into from
Jan 24, 2019

Conversation

GregTheGreek
Copy link
Member

Switched to little-edian Per #23

Caveat: Tests are failing/ hanging

@wemeetagain
Copy link
Member

read/writeIntBytes in src/intBytes.js need be -> le

@GregTheGreek
Copy link
Member Author

@wemeetagain Thanks, now I'll need to fix ~30 tests. lol

@wemeetagain
Copy link
Member

fyi, prysm's ssz, where some of our test cases originate, has moved to little-endian.
Should be straightforward to adjust those test cases now.

@GregTheGreek
Copy link
Member Author

GregTheGreek commented Jan 22, 2019 •
edited
Loading

@wemeetagain
Awesome going to work on it today!

@GregTheGreek GregTheGreek self-assigned this Jan 23, 2019
@GregTheGreek
Copy link
Member Author

@wemeetagain Up to date :)

@GregTheGreek GregTheGreek requested review from ChainSafeSystems and a team January 23, 2019 21:47
wemeetagain
wemeetagain approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

My comments are both small styling nits in the tests.
Perhaps we should lint our tests as well in the future.

test/test_ssz_deserialize.js Outdated Show resolved Hide resolved
test/test_ssz_deserialize.js Outdated Show resolved Hide resolved
@GregTheGreek
Copy link
Member Author

Definitely need a linter.

@GregTheGreek GregTheGreek merged commit 5dc535b into master Jan 24, 2019
@GregTheGreek GregTheGreek mentioned this pull request Jan 24, 2019
Closed
@wemeetagain wemeetagain deleted the greg/little-edian branch April 3, 2019 14:53
@jonathanpwang jonathanpwang mentioned this pull request Apr 26, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChainSafeSystems ChainSafeSystems ChainSafeSystems approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees

@GregTheGreek GregTheGreek

Labels
PR state: blocked PR state: WIP priority: P3 important type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregTheGreek @wemeetagain @ChainSafeSystems