Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename getValidatorMaxEffectiveBalance #7070

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat: rename getValidatorMaxEffectiveBalance #7070

merged 2 commits into from
Sep 9, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Sep 6, 2024

Rename getValidatorMaxEffectiveBalance to getMaxEffectiveBalance. This rename will be in effect in the next release of consensus spec which will be the target of devnet-4.

We can rename now for devnet-3 since no functional impact.

@ensi321 ensi321 requested a review from a team as a code owner September 6, 2024 22:08
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (4e22884) to head (1f42b8a).
Report is 3 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7070   +/-   ##
=========================================
  Coverage     49.26%   49.27%           
=========================================
  Files           592      592           
  Lines         39365    39371    +6     
  Branches       2251     2242    -9     
=========================================
+ Hits          19393    19399    +6     
  Misses        19931    19931           
  Partials         41       41

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: cecd13a Previous: b05c93e Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.8736 ms/op 1.8922 ms/op 0.99
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 37.326 us/op 50.311 us/op 0.74
BLS verify - blst 914.54 us/op 910.11 us/op 1.00
BLS verifyMultipleSignatures 3 - blst 1.2779 ms/op 1.2178 ms/op 1.05
BLS verifyMultipleSignatures 8 - blst 2.0289 ms/op 1.9058 ms/op 1.06
BLS verifyMultipleSignatures 32 - blst 4.5374 ms/op 5.4504 ms/op 0.83
BLS verifyMultipleSignatures 64 - blst 8.5125 ms/op 10.784 ms/op 0.79
BLS verifyMultipleSignatures 128 - blst 16.052 ms/op 17.466 ms/op 0.92
BLS deserializing 10000 signatures 630.08 ms/op 682.83 ms/op 0.92
BLS deserializing 100000 signatures 6.3691 s/op 6.8248 s/op 0.93
BLS verifyMultipleSignatures - same message - 3 - blst 1.0196 ms/op 976.91 us/op 1.04
BLS verifyMultipleSignatures - same message - 8 - blst 1.1122 ms/op 1.0508 ms/op 1.06
BLS verifyMultipleSignatures - same message - 32 - blst 1.7398 ms/op 1.7194 ms/op 1.01
BLS verifyMultipleSignatures - same message - 64 - blst 2.6216 ms/op 2.6214 ms/op 1.00
BLS verifyMultipleSignatures - same message - 128 - blst 4.2601 ms/op 4.3843 ms/op 0.97
BLS aggregatePubkeys 32 - blst 17.996 us/op 20.089 us/op 0.90
BLS aggregatePubkeys 128 - blst 64.218 us/op 70.620 us/op 0.91
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 45.060 ms/op 66.242 ms/op 0.68
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 52.211 ms/op 65.782 ms/op 0.79
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 41.300 ms/op 40.036 ms/op 1.03
getSlashingsAndExits - default max 67.478 us/op 95.929 us/op 0.70
getSlashingsAndExits - 2k 260.01 us/op 325.96 us/op 0.80
proposeBlockBody type=full, size=empty 5.1238 ms/op 5.8315 ms/op 0.88
isKnown best case - 1 super set check 595.00 ns/op 337.00 ns/op 1.77
isKnown normal case - 2 super set checks 626.00 ns/op 323.00 ns/op 1.94
isKnown worse case - 16 super set checks 679.00 ns/op 308.00 ns/op 2.20
InMemoryCheckpointStateCache - add get delete 2.8200 us/op 3.1530 us/op 0.89
updateUnfinalizedPubkeys - updating 10 pubkeys 826.62 us/op 619.81 us/op 1.33
updateUnfinalizedPubkeys - updating 100 pubkeys 2.3363 ms/op 3.1527 ms/op 0.74
updateUnfinalizedPubkeys - updating 1000 pubkeys 46.579 ms/op 55.751 ms/op 0.84
validate api signedAggregateAndProof - struct 1.4771 ms/op 1.6223 ms/op 0.91
validate gossip signedAggregateAndProof - struct 1.4918 ms/op 2.5773 ms/op 0.58
validate gossip attestation - vc 640000 1.0020 ms/op 1.1353 ms/op 0.88
batch validate gossip attestation - vc 640000 - chunk 32 123.89 us/op 138.26 us/op 0.90
batch validate gossip attestation - vc 640000 - chunk 64 102.21 us/op 114.88 us/op 0.89
batch validate gossip attestation - vc 640000 - chunk 128 98.400 us/op 107.09 us/op 0.92
batch validate gossip attestation - vc 640000 - chunk 256 94.300 us/op 106.31 us/op 0.89
pickEth1Vote - no votes 910.57 us/op 1.2374 ms/op 0.74
pickEth1Vote - max votes 5.6777 ms/op 8.7804 ms/op 0.65
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.179 ms/op 13.294 ms/op 1.14
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.067 ms/op 19.563 ms/op 1.08
pickEth1Vote - Eth1Data fastSerialize value x2048 367.88 us/op 488.64 us/op 0.75
pickEth1Vote - Eth1Data fastSerialize tree x2048 2.6733 ms/op 2.7160 ms/op 0.98
bytes32 toHexString 583.00 ns/op 475.00 ns/op 1.23
bytes32 Buffer.toString(hex) 437.00 ns/op 264.00 ns/op 1.66
bytes32 Buffer.toString(hex) from Uint8Array 521.00 ns/op 390.00 ns/op 1.34
bytes32 Buffer.toString(hex) + 0x 431.00 ns/op 270.00 ns/op 1.60
Object access 1 prop 0.32200 ns/op 0.16000 ns/op 2.01
Map access 1 prop 0.32300 ns/op 0.15200 ns/op 2.13
Object get x1000 5.0570 ns/op 6.0560 ns/op 0.84
Map get x1000 5.8820 ns/op 6.7270 ns/op 0.87
Object set x1000 25.956 ns/op 35.636 ns/op 0.73
Map set x1000 19.122 ns/op 24.800 ns/op 0.77
Return object 10000 times 0.29600 ns/op 0.29920 ns/op 0.99
Throw Error 10000 times 2.6586 us/op 3.4705 us/op 0.77
toHex 100.23 ns/op 149.65 ns/op 0.67
Buffer.from 92.652 ns/op 139.04 ns/op 0.67
shared Buffer 65.009 ns/op 89.769 ns/op 0.72
fastMsgIdFn sha256 / 200 bytes 2.0070 us/op 2.3200 us/op 0.87
fastMsgIdFn h32 xxhash / 200 bytes 429.00 ns/op 245.00 ns/op 1.75
fastMsgIdFn h64 xxhash / 200 bytes 449.00 ns/op 280.00 ns/op 1.60
fastMsgIdFn sha256 / 1000 bytes 5.5230 us/op 7.8060 us/op 0.71
fastMsgIdFn h32 xxhash / 1000 bytes 527.00 ns/op 383.00 ns/op 1.38
fastMsgIdFn h64 xxhash / 1000 bytes 536.00 ns/op 364.00 ns/op 1.47
fastMsgIdFn sha256 / 10000 bytes 46.083 us/op 66.111 us/op 0.70
fastMsgIdFn h32 xxhash / 10000 bytes 1.8940 us/op 1.9200 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.2990 us/op 1.2590 us/op 1.03
send data - 1000 256B messages 9.6953 ms/op 13.248 ms/op 0.73
send data - 1000 512B messages 13.139 ms/op 17.720 ms/op 0.74
send data - 1000 1024B messages 20.962 ms/op 26.656 ms/op 0.79
send data - 1000 1200B messages 22.682 ms/op 23.076 ms/op 0.98
send data - 1000 2048B messages 29.943 ms/op 32.507 ms/op 0.92
send data - 1000 4096B messages 27.010 ms/op 32.327 ms/op 0.84
send data - 1000 16384B messages 63.363 ms/op 75.337 ms/op 0.84
send data - 1000 65536B messages 246.13 ms/op 223.62 ms/op 1.10
enrSubnets - fastDeserialize 64 bits 1.0540 us/op 1.0880 us/op 0.97
enrSubnets - ssz BitVector 64 bits 506.00 ns/op 402.00 ns/op 1.26
enrSubnets - fastDeserialize 4 bits 319.00 ns/op 195.00 ns/op 1.64
enrSubnets - ssz BitVector 4 bits 548.00 ns/op 447.00 ns/op 1.23
prioritizePeers score -10:0 att 32-0.1 sync 2-0 127.64 us/op 175.39 us/op 0.73
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 155.36 us/op 195.94 us/op 0.79
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 290.88 us/op 391.73 us/op 0.74
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 478.23 us/op 481.67 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 536.69 us/op 739.55 us/op 0.73
array of 16000 items push then shift 1.2360 us/op 1.6761 us/op 0.74
LinkedList of 16000 items push then shift 7.1500 ns/op 7.8510 ns/op 0.91
array of 16000 items push then pop 91.513 ns/op 140.00 ns/op 0.65
LinkedList of 16000 items push then pop 6.0670 ns/op 7.8060 ns/op 0.78
array of 24000 items push then shift 1.8227 us/op 2.5742 us/op 0.71
LinkedList of 24000 items push then shift 6.6040 ns/op 8.4590 ns/op 0.78
array of 24000 items push then pop 111.72 ns/op 188.23 ns/op 0.59
LinkedList of 24000 items push then pop 5.9850 ns/op 7.6230 ns/op 0.79
intersect bitArray bitLen 8 5.2170 ns/op 6.6780 ns/op 0.78
intersect array and set length 8 39.377 ns/op 54.364 ns/op 0.72
intersect bitArray bitLen 128 25.488 ns/op 31.345 ns/op 0.81
intersect array and set length 128 552.05 ns/op 929.26 ns/op 0.59
bitArray.getTrueBitIndexes() bitLen 128 1.9090 us/op 2.3200 us/op 0.82
bitArray.getTrueBitIndexes() bitLen 248 3.8700 us/op 4.3940 us/op 0.88
bitArray.getTrueBitIndexes() bitLen 512 6.5470 us/op 9.7670 us/op 0.67
Buffer.concat 32 items 980.00 ns/op 1.0730 us/op 0.91
Uint8Array.set 32 items 1.7080 us/op 1.6300 us/op 1.05
Buffer.copy 1.9060 us/op 2.1820 us/op 0.87
Uint8Array.set - with subarray 2.5220 us/op 3.1510 us/op 0.80
Uint8Array.set - without subarray 1.6680 us/op 1.6310 us/op 1.02
getUint32 - dataview 409.00 ns/op 316.00 ns/op 1.29
getUint32 - manual 331.00 ns/op 255.00 ns/op 1.30
Set add up to 64 items then delete first 1.7704 us/op 2.7536 us/op 0.64
OrderedSet add up to 64 items then delete first 2.8093 us/op 4.0716 us/op 0.69
Set add up to 64 items then delete last 2.0423 us/op 2.9983 us/op 0.68
OrderedSet add up to 64 items then delete last 3.1147 us/op 4.7860 us/op 0.65
Set add up to 64 items then delete middle 1.9291 us/op 2.6288 us/op 0.73
OrderedSet add up to 64 items then delete middle 4.2570 us/op 6.3458 us/op 0.67
Set add up to 128 items then delete first 3.8323 us/op 5.9284 us/op 0.65
OrderedSet add up to 128 items then delete first 6.0166 us/op 10.197 us/op 0.59
Set add up to 128 items then delete last 3.6517 us/op 5.8826 us/op 0.62
OrderedSet add up to 128 items then delete last 5.6038 us/op 8.8673 us/op 0.63
Set add up to 128 items then delete middle 3.6836 us/op 5.8234 us/op 0.63
OrderedSet add up to 128 items then delete middle 11.450 us/op 15.080 us/op 0.76
Set add up to 256 items then delete first 7.4824 us/op 10.754 us/op 0.70
OrderedSet add up to 256 items then delete first 12.170 us/op 16.999 us/op 0.72
Set add up to 256 items then delete last 7.2133 us/op 11.025 us/op 0.65
OrderedSet add up to 256 items then delete last 11.400 us/op 16.788 us/op 0.68
Set add up to 256 items then delete middle 7.2353 us/op 10.133 us/op 0.71
OrderedSet add up to 256 items then delete middle 32.899 us/op 43.009 us/op 0.76
transfer serialized Status (84 B) 1.4920 us/op 1.4900 us/op 1.00
copy serialized Status (84 B) 1.2790 us/op 1.2340 us/op 1.04
transfer serialized SignedVoluntaryExit (112 B) 1.5540 us/op 1.5790 us/op 0.98
copy serialized SignedVoluntaryExit (112 B) 1.3410 us/op 1.2630 us/op 1.06
transfer serialized ProposerSlashing (416 B) 2.1010 us/op 2.0960 us/op 1.00
copy serialized ProposerSlashing (416 B) 1.7230 us/op 1.8120 us/op 0.95
transfer serialized Attestation (485 B) 2.2870 us/op 1.9030 us/op 1.20
copy serialized Attestation (485 B) 2.4120 us/op 1.8250 us/op 1.32
transfer serialized AttesterSlashing (33232 B) 2.4180 us/op 2.5030 us/op 0.97
copy serialized AttesterSlashing (33232 B) 4.6100 us/op 5.4330 us/op 0.85
transfer serialized Small SignedBeaconBlock (128000 B) 2.7660 us/op 3.0420 us/op 0.91
copy serialized Small SignedBeaconBlock (128000 B) 10.116 us/op 15.933 us/op 0.63
transfer serialized Avg SignedBeaconBlock (200000 B) 3.7660 us/op 3.4720 us/op 1.08
copy serialized Avg SignedBeaconBlock (200000 B) 13.467 us/op 21.993 us/op 0.61
transfer serialized BlobsSidecar (524380 B) 3.0240 us/op 3.2270 us/op 0.94
copy serialized BlobsSidecar (524380 B) 77.869 us/op 97.114 us/op 0.80
transfer serialized Big SignedBeaconBlock (1000000 B) 3.1030 us/op 3.2000 us/op 0.97
copy serialized Big SignedBeaconBlock (1000000 B) 340.51 us/op 258.56 us/op 1.32
pass gossip attestations to forkchoice per slot 2.3714 ms/op 2.8533 ms/op 0.83
forkChoice updateHead vc 100000 bc 64 eq 0 531.23 us/op 497.46 us/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 0 2.5196 ms/op 3.9550 ms/op 0.64
forkChoice updateHead vc 1000000 bc 64 eq 0 4.1291 ms/op 5.2531 ms/op 0.79
forkChoice updateHead vc 600000 bc 320 eq 0 2.4203 ms/op 3.0745 ms/op 0.79
forkChoice updateHead vc 600000 bc 1200 eq 0 2.5094 ms/op 3.2760 ms/op 0.77
forkChoice updateHead vc 600000 bc 7200 eq 0 2.7857 ms/op 3.7638 ms/op 0.74
forkChoice updateHead vc 600000 bc 64 eq 1000 9.7928 ms/op 10.896 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 10000 9.1481 ms/op 10.949 ms/op 0.84
forkChoice updateHead vc 600000 bc 64 eq 300000 12.094 ms/op 14.463 ms/op 0.84
computeDeltas 500000 validators 300 proto nodes 2.9187 ms/op 3.7476 ms/op 0.78
computeDeltas 500000 validators 1200 proto nodes 2.9359 ms/op 3.7564 ms/op 0.78
computeDeltas 500000 validators 7200 proto nodes 2.9751 ms/op 3.8664 ms/op 0.77
computeDeltas 750000 validators 300 proto nodes 4.3744 ms/op 5.4558 ms/op 0.80
computeDeltas 750000 validators 1200 proto nodes 4.3761 ms/op 5.4714 ms/op 0.80
computeDeltas 750000 validators 7200 proto nodes 4.2866 ms/op 5.3540 ms/op 0.80
computeDeltas 1400000 validators 300 proto nodes 8.0277 ms/op 10.441 ms/op 0.77
computeDeltas 1400000 validators 1200 proto nodes 8.0407 ms/op 10.633 ms/op 0.76
computeDeltas 1400000 validators 7200 proto nodes 8.3498 ms/op 10.172 ms/op 0.82
computeDeltas 2100000 validators 300 proto nodes 12.102 ms/op 15.100 ms/op 0.80
computeDeltas 2100000 validators 1200 proto nodes 12.097 ms/op 15.241 ms/op 0.79
computeDeltas 2100000 validators 7200 proto nodes 12.270 ms/op 15.623 ms/op 0.79
altair processAttestation - 250000 vs - 7PWei normalcase 1.4758 ms/op 2.1149 ms/op 0.70
altair processAttestation - 250000 vs - 7PWei worstcase 2.3023 ms/op 3.5275 ms/op 0.65
altair processAttestation - setStatus - 1/6 committees join 87.551 us/op 103.77 us/op 0.84
altair processAttestation - setStatus - 1/3 committees join 177.54 us/op 175.70 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 257.65 us/op 245.06 us/op 1.05
altair processAttestation - setStatus - 2/3 committees join 336.10 us/op 325.33 us/op 1.03
altair processAttestation - setStatus - 4/5 committees join 486.24 us/op 479.87 us/op 1.01
altair processAttestation - setStatus - 100% committees join 549.91 us/op 573.26 us/op 0.96
altair processBlock - 250000 vs - 7PWei normalcase 3.4084 ms/op 4.2532 ms/op 0.80
altair processBlock - 250000 vs - 7PWei normalcase hashState 20.093 ms/op 27.265 ms/op 0.74
altair processBlock - 250000 vs - 7PWei worstcase 35.954 ms/op 41.032 ms/op 0.88
altair processBlock - 250000 vs - 7PWei worstcase hashState 61.249 ms/op 93.696 ms/op 0.65
phase0 processBlock - 250000 vs - 7PWei normalcase 1.6345 ms/op 2.6724 ms/op 0.61
phase0 processBlock - 250000 vs - 7PWei worstcase 21.766 ms/op 25.272 ms/op 0.86
altair processEth1Data - 250000 vs - 7PWei normalcase 257.58 us/op 375.11 us/op 0.69
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 3.9920 us/op 6.8920 us/op 0.58
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 28.650 us/op 37.023 us/op 0.77
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.4660 us/op 9.7680 us/op 0.87
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 4.9800 us/op 6.2710 us/op 0.79
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 132.86 us/op 158.84 us/op 0.84
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 809.42 us/op 1.3477 ms/op 0.60
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.1631 ms/op 1.8789 ms/op 0.62
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.2077 ms/op 1.5759 ms/op 0.77
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.0614 ms/op 3.5937 ms/op 0.85
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.2243 ms/op 2.4625 ms/op 0.50
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.0727 ms/op 3.4929 ms/op 0.88
Tree 40 250000 create 190.51 ms/op 217.23 ms/op 0.88
Tree 40 250000 get(125000) 113.64 ns/op 153.43 ns/op 0.74
Tree 40 250000 set(125000) 539.04 ns/op 700.02 ns/op 0.77
Tree 40 250000 toArray() 9.7620 ms/op 20.130 ms/op 0.48
Tree 40 250000 iterate all - toArray() + loop 9.8405 ms/op 20.919 ms/op 0.47
Tree 40 250000 iterate all - get(i) 40.353 ms/op 57.789 ms/op 0.70
Array 250000 create 2.4524 ms/op 3.2383 ms/op 0.76
Array 250000 clone - spread 1.3417 ms/op 1.4802 ms/op 0.91
Array 250000 get(125000) 0.61000 ns/op 0.42100 ns/op 1.45
Array 250000 set(125000) 0.61600 ns/op 0.43100 ns/op 1.43
Array 250000 iterate all - loop 79.204 us/op 82.040 us/op 0.97
phase0 afterProcessEpoch - 250000 vs - 7PWei 79.370 ms/op 94.741 ms/op 0.84
Array.fill - length 1000000 2.6626 ms/op 3.8215 ms/op 0.70
Array push - length 1000000 9.4583 ms/op 21.785 ms/op 0.43
Array.get 0.26879 ns/op 0.29227 ns/op 0.92
Uint8Array.get 0.34720 ns/op 0.44766 ns/op 0.78
phase0 beforeProcessEpoch - 250000 vs - 7PWei 12.663 ms/op 17.651 ms/op 0.72
altair processEpoch - mainnet_e81889 280.03 ms/op 359.23 ms/op 0.78
mainnet_e81889 - altair beforeProcessEpoch 16.462 ms/op 18.440 ms/op 0.89
mainnet_e81889 - altair processJustificationAndFinalization 9.9080 us/op 17.955 us/op 0.55
mainnet_e81889 - altair processInactivityUpdates 4.1106 ms/op 5.2782 ms/op 0.78
mainnet_e81889 - altair processRewardsAndPenalties 35.657 ms/op 59.699 ms/op 0.60
mainnet_e81889 - altair processRegistryUpdates 1.7760 us/op 3.0090 us/op 0.59
mainnet_e81889 - altair processSlashings 739.00 ns/op 605.00 ns/op 1.22
mainnet_e81889 - altair processEth1DataReset 668.00 ns/op 379.00 ns/op 1.76
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.0833 ms/op 2.6697 ms/op 0.41
mainnet_e81889 - altair processSlashingsReset 4.3320 us/op 2.5420 us/op 1.70
mainnet_e81889 - altair processRandaoMixesReset 3.7720 us/op 3.1160 us/op 1.21
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0910 us/op 832.00 ns/op 1.31
mainnet_e81889 - altair processParticipationFlagUpdates 2.2170 us/op 3.0030 us/op 0.74
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0580 us/op 477.00 ns/op 2.22
mainnet_e81889 - altair afterProcessEpoch 81.322 ms/op 99.297 ms/op 0.82
capella processEpoch - mainnet_e217614 1.0360 s/op 1.2617 s/op 0.82
mainnet_e217614 - capella beforeProcessEpoch 70.506 ms/op 73.985 ms/op 0.95
mainnet_e217614 - capella processJustificationAndFinalization 15.539 us/op 23.602 us/op 0.66
mainnet_e217614 - capella processInactivityUpdates 12.341 ms/op 16.281 ms/op 0.76
mainnet_e217614 - capella processRewardsAndPenalties 224.60 ms/op 280.78 ms/op 0.80
mainnet_e217614 - capella processRegistryUpdates 10.754 us/op 20.223 us/op 0.53
mainnet_e217614 - capella processSlashings 767.00 ns/op 658.00 ns/op 1.17
mainnet_e217614 - capella processEth1DataReset 682.00 ns/op 603.00 ns/op 1.13
mainnet_e217614 - capella processEffectiveBalanceUpdates 16.227 ms/op 12.762 ms/op 1.27
mainnet_e217614 - capella processSlashingsReset 2.3260 us/op 3.1980 us/op 0.73
mainnet_e217614 - capella processRandaoMixesReset 3.3240 us/op 4.3990 us/op 0.76
mainnet_e217614 - capella processHistoricalRootsUpdate 680.00 ns/op 479.00 ns/op 1.42
mainnet_e217614 - capella processParticipationFlagUpdates 3.5550 us/op 3.9390 us/op 0.90
mainnet_e217614 - capella afterProcessEpoch 202.87 ms/op 238.58 ms/op 0.85
phase0 processEpoch - mainnet_e58758 412.96 ms/op 436.80 ms/op 0.95
mainnet_e58758 - phase0 beforeProcessEpoch 61.620 ms/op 83.891 ms/op 0.73
mainnet_e58758 - phase0 processJustificationAndFinalization 12.084 us/op 22.790 us/op 0.53
mainnet_e58758 - phase0 processRewardsAndPenalties 25.676 ms/op 36.336 ms/op 0.71
mainnet_e58758 - phase0 processRegistryUpdates 6.3660 us/op 12.488 us/op 0.51
mainnet_e58758 - phase0 processSlashings 721.00 ns/op 490.00 ns/op 1.47
mainnet_e58758 - phase0 processEth1DataReset 734.00 ns/op 548.00 ns/op 1.34
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3680 ms/op 2.9223 ms/op 0.47
mainnet_e58758 - phase0 processSlashingsReset 2.7960 us/op 4.1130 us/op 0.68
mainnet_e58758 - phase0 processRandaoMixesReset 3.9530 us/op 5.7890 us/op 0.68
mainnet_e58758 - phase0 processHistoricalRootsUpdate 734.00 ns/op 469.00 ns/op 1.57
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.9680 us/op 4.3250 us/op 0.69
mainnet_e58758 - phase0 afterProcessEpoch 69.486 ms/op 82.402 ms/op 0.84
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0342 ms/op 1.3079 ms/op 0.79
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4525 ms/op 2.1866 ms/op 0.66
altair processInactivityUpdates - 250000 normalcase 16.874 ms/op 21.012 ms/op 0.80
altair processInactivityUpdates - 250000 worstcase 16.854 ms/op 21.391 ms/op 0.79
phase0 processRegistryUpdates - 250000 normalcase 5.2490 us/op 6.1370 us/op 0.86
phase0 processRegistryUpdates - 250000 badcase_full_deposits 316.78 us/op 341.00 us/op 0.93
phase0 processRegistryUpdates - 250000 worstcase 0.5 126.65 ms/op 122.16 ms/op 1.04
altair processRewardsAndPenalties - 250000 normalcase 49.056 ms/op 48.660 ms/op 1.01
altair processRewardsAndPenalties - 250000 worstcase 39.251 ms/op 56.556 ms/op 0.69
phase0 getAttestationDeltas - 250000 normalcase 6.4115 ms/op 7.1894 ms/op 0.89
phase0 getAttestationDeltas - 250000 worstcase 6.5332 ms/op 7.0507 ms/op 0.93
phase0 processSlashings - 250000 worstcase 92.051 us/op 120.83 us/op 0.76
altair processSyncCommitteeUpdates - 250000 94.899 ms/op 121.16 ms/op 0.78
BeaconState.hashTreeRoot - No change 478.00 ns/op 258.00 ns/op 1.85
BeaconState.hashTreeRoot - 1 full validator 84.656 us/op 147.99 us/op 0.57
BeaconState.hashTreeRoot - 32 full validator 1.1429 ms/op 1.6052 ms/op 0.71
BeaconState.hashTreeRoot - 512 full validator 13.298 ms/op 13.486 ms/op 0.99
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 148.84 us/op 142.53 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.7189 ms/op 2.1058 ms/op 0.82
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 18.458 ms/op 29.176 ms/op 0.63
BeaconState.hashTreeRoot - 1 balances 68.023 us/op 133.49 us/op 0.51
BeaconState.hashTreeRoot - 32 balances 635.35 us/op 1.1740 ms/op 0.54
BeaconState.hashTreeRoot - 512 balances 9.6301 ms/op 11.658 ms/op 0.83
BeaconState.hashTreeRoot - 250000 balances 143.92 ms/op 190.76 ms/op 0.75
aggregationBits - 2048 els - zipIndexesInBitList 19.367 us/op 23.370 us/op 0.83
byteArrayEquals 32 49.118 ns/op 51.519 ns/op 0.95
Buffer.compare 32 15.754 ns/op 16.419 ns/op 0.96
byteArrayEquals 1024 1.2945 us/op 1.5260 us/op 0.85
Buffer.compare 1024 23.626 ns/op 23.599 ns/op 1.00
byteArrayEquals 16384 20.585 us/op 24.250 us/op 0.85
Buffer.compare 16384 206.92 ns/op 190.85 ns/op 1.08
byteArrayEquals 123687377 153.05 ms/op 183.35 ms/op 0.83
Buffer.compare 123687377 4.0444 ms/op 6.1803 ms/op 0.65
byteArrayEquals 32 - diff last byte 46.047 ns/op 51.871 ns/op 0.89
Buffer.compare 32 - diff last byte 15.797 ns/op 16.811 ns/op 0.94
byteArrayEquals 1024 - diff last byte 1.2581 us/op 1.5570 us/op 0.81
Buffer.compare 1024 - diff last byte 24.209 ns/op 25.262 ns/op 0.96
byteArrayEquals 16384 - diff last byte 19.952 us/op 24.810 us/op 0.80
Buffer.compare 16384 - diff last byte 176.09 ns/op 195.81 ns/op 0.90
byteArrayEquals 123687377 - diff last byte 151.22 ms/op 185.48 ms/op 0.82
Buffer.compare 123687377 - diff last byte 3.8081 ms/op 6.1979 ms/op 0.61
byteArrayEquals 32 - random bytes 4.8830 ns/op 5.0080 ns/op 0.98
Buffer.compare 32 - random bytes 16.395 ns/op 16.699 ns/op 0.98
byteArrayEquals 1024 - random bytes 4.8650 ns/op 5.0240 ns/op 0.97
Buffer.compare 1024 - random bytes 16.036 ns/op 16.664 ns/op 0.96
byteArrayEquals 16384 - random bytes 5.0170 ns/op 5.0120 ns/op 1.00
Buffer.compare 16384 - random bytes 16.042 ns/op 17.000 ns/op 0.94
byteArrayEquals 123687377 - random bytes 7.7600 ns/op 6.3100 ns/op 1.23
Buffer.compare 123687377 - random bytes 19.170 ns/op 17.950 ns/op 1.07
regular array get 100000 times 30.758 us/op 41.309 us/op 0.74
wrappedArray get 100000 times 30.747 us/op 32.121 us/op 0.96
arrayWithProxy get 100000 times 9.8635 ms/op 14.838 ms/op 0.66
ssz.Root.equals 43.347 ns/op 44.671 ns/op 0.97
byteArrayEquals 42.448 ns/op 43.937 ns/op 0.97
Buffer.compare 9.2360 ns/op 10.101 ns/op 0.91
shuffle list - 16384 els 5.3744 ms/op 5.9155 ms/op 0.91
shuffle list - 250000 els 79.625 ms/op 87.288 ms/op 0.91
processSlot - 1 slots 14.711 us/op 14.754 us/op 1.00
processSlot - 32 slots 2.9575 ms/op 3.4247 ms/op 0.86
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 43.058 ms/op 42.149 ms/op 1.02
getCommitteeAssignments - req 1 vs - 250000 vc 1.7007 ms/op 2.1085 ms/op 0.81
getCommitteeAssignments - req 100 vs - 250000 vc 3.3526 ms/op 4.0632 ms/op 0.83
getCommitteeAssignments - req 1000 vs - 250000 vc 3.6558 ms/op 4.4299 ms/op 0.83
findModifiedValidators - 10000 modified validators 214.83 ms/op 248.60 ms/op 0.86
findModifiedValidators - 1000 modified validators 139.10 ms/op 173.35 ms/op 0.80
findModifiedValidators - 100 modified validators 141.97 ms/op 157.35 ms/op 0.90
findModifiedValidators - 10 modified validators 141.20 ms/op 163.10 ms/op 0.87
findModifiedValidators - 1 modified validators 119.89 ms/op 157.23 ms/op 0.76
findModifiedValidators - no difference 137.90 ms/op 161.34 ms/op 0.85
compare ViewDUs 3.1587 s/op 3.1548 s/op 1.00
compare each validator Uint8Array 1.5549 s/op 1.8921 s/op 0.82
compare ViewDU to Uint8Array 665.40 ms/op 959.79 ms/op 0.69
migrate state 1000000 validators, 24 modified, 0 new 586.83 ms/op 622.81 ms/op 0.94
migrate state 1000000 validators, 1700 modified, 1000 new 837.42 ms/op 876.93 ms/op 0.95
migrate state 1000000 validators, 3400 modified, 2000 new 1.0331 s/op 1.1290 s/op 0.92
migrate state 1500000 validators, 24 modified, 0 new 601.31 ms/op 634.19 ms/op 0.95
migrate state 1500000 validators, 1700 modified, 1000 new 833.82 ms/op 897.46 ms/op 0.93
migrate state 1500000 validators, 3400 modified, 2000 new 1.0393 s/op 1.1186 s/op 0.93
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.9900 ns/op 4.5300 ns/op 1.32
state getBlockRootAtSlot - 250000 vs - 7PWei 621.03 ns/op 686.92 ns/op 0.90
computeProposers - vc 250000 6.5625 ms/op 8.2807 ms/op 0.79
computeEpochShuffling - vc 250000 81.932 ms/op 92.225 ms/op 0.89
getNextSyncCommittee - vc 250000 100.02 ms/op 129.70 ms/op 0.77
computeSigningRoot for AttestationData 20.873 us/op 20.795 us/op 1.00
hash AttestationData serialized data then Buffer.toString(base64) 1.1213 us/op 1.5428 us/op 0.73
toHexString serialized data 716.41 ns/op 944.59 ns/op 0.76
Buffer.toString(base64) 143.33 ns/op 185.19 ns/op 0.77
nodejs block root to RootHex using toHex 113.79 ns/op 146.32 ns/op 0.78
nodejs block root to RootHex using toRootHex 75.927 ns/op 88.568 ns/op 0.86
browser block root to RootHex using the deprecated toHexString 203.06 ns/op 227.77 ns/op 0.89
browser block root to RootHex using toHex 156.31 ns/op 184.91 ns/op 0.85
browser block root to RootHex using toRootHex 140.88 ns/op 171.18 ns/op 0.82

by benchmarkbot/action

twoeths
twoeths previously approved these changes Sep 7, 2024
View reviewed changes
@wemeetagain wemeetagain merged commit 0e79d29 into unstable Sep 9, 2024
20 checks passed
@wemeetagain wemeetagain deleted the nc/helper-rename branch September 9, 2024 21:35
philknows pushed a commit that referenced this pull request Sep 11, 2024
@ensi321 @philknows
feat: rename getValidatorMaxEffectiveBalance (#7070)
43c11ee 
* Rename getValidatorMaxEffectiveBalance

* Lint
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@twoeths twoeths twoeths left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ensi321 @wemeetagain @twoeths