-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove assumption of 3 intervals per slot #7067
Open
ensi321
wants to merge
3
commits into
unstable
Choose a base branch
from
slot-intervals
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
force-pushed
the
slot-intervals
branch
from
September 16, 2024 23:40
1847a6e
to
82fc1b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7067 +/- ##
============================================
+ Coverage 50.90% 50.93% +0.02%
============================================
Files 594 595 +1
Lines 39611 39676 +65
Branches 2248 2259 +11
============================================
+ Hits 20163 20207 +44
- Misses 19448 19469 +21 |
Performance Report✔️ no performance regression detected Full benchmark results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of places in Lodestar codebase that assume 3 intervals per slot and thus hard code
3
when calculating seconds into the slot.In preparation of ePBS, or future protocol upgrades that might potentially introduce more intervals per slot, we should refactor our codebase to remove such assumption.
1 / 3
,2 / 3
hardcodedSlotInterval
to explicitly lay out what validator actions should happen at which interval