Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename execution payload header type guard #6906

Merged
merged 1 commit into from
Jun 25, 2024
Merged

chore: rename execution payload header type guard #6906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/beacon-node/test/e2e/api/impl/beacon/block/endpoint.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import {ApiClient, WireFormat, getClient} from "@lodestar/api";
import {
SignedBeaconBlock,
SignedBlindedBeaconBlock,
isBlindedExecutionPayload,
isBlindedSignedBeaconBlock,
isExecutionPayload,
isExecutionPayloadHeader,
} from "@lodestar/types";
import {ForkName} from "@lodestar/params";
import {LogLevel, testLogger} from "../../../../../utils/logger.js";
Expand Down Expand Up @@ -84,7 +84,7 @@ describe("beacon block api", function () {
const blindedBlock = res.value() as SignedBlindedBeaconBlock<typeof fork>;

expect(isBlindedSignedBeaconBlock(blindedBlock)).toBe(true);
expect(isBlindedExecutionPayload(blindedBlock.message.body.executionPayloadHeader)).toBe(true);
expect(isExecutionPayloadHeader(blindedBlock.message.body.executionPayloadHeader)).toBe(true);
expect(blindedBlock.message.body).not.toHaveProperty("executionPayload");
});

Expand Down
2 changes: 1 addition & 1 deletion packages/types/src/utils/typeguards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function isExecutionPayload<F extends ForkExecution>(
return (payload as ExecutionPayload<F>).transactions !== undefined;
}

export function isBlindedExecutionPayload<F extends ForkExecution>(
export function isExecutionPayloadHeader<F extends ForkExecution>(
payload: ExecutionPayload<F> | ExecutionPayloadHeader<F>
): payload is ExecutionPayloadHeader<F> {
// we just check transactionsRoot for determining as it the base field
Expand Down
Loading