test: update clock tests to run deterministically #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nazarhussain
previously requested changes
May 30, 2024
Comment on lines
+91
to
+93
| beforeEach(() => { | ||
| vi.setSystemTime(genesisTime * 1000); | ||
| }); |
There was a problem hiding this comment.
We are using vi.useFakeTimers({now: Date.now()}); that config now is enough to make the tests deterministic. If any regression detected we should try to hardcode value now to a static value.
There was a problem hiding this comment.
that config now is enough to make the tests deterministic
but the test is not deterministic, see #6734 (comment)
There was a problem hiding this comment.
Another failed run on unstable, we should merge this
nflaig
reviewed
Jun 1, 2024
nflaig
approved these changes
Jun 7, 2024
nflaig
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6828 +/- ##
============================================
- Coverage 62.21% 62.19% -0.02%
============================================
Files 571 571
Lines 60017 60021 +4
Branches 1975 1973 -2
============================================
- Hits 37338 37333 -5
- Misses 22636 22645 +9
Partials 43 43 |
|
🎉 This PR is included in v1.20.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clock tests at
clock.test.tskeep failing from time to time due to edge cases arising from the use ofDate.nowThis aims to fix that.
Description
This change overrides the system time before each test case to make the tests run deterministically.
Closes #6734