Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.9.1 #5718

Merged
merged 7 commits into from
Jun 30, 2023
Merged

chore: release v1.9.1 #5718

merged 7 commits into from
Jun 30, 2023

Conversation

philknows
Copy link
Member

@philknows philknows commented Jun 28, 2023

Motivation

Team agreed to pushing a patch release to address some fixes for users before a v1.10 release.

Description

Added #5664, #5708 , #5715 , #5714 , #5716 and #5717 to stable branch.

Steps to test or reproduce

@philknows philknows requested a review from a team as a code owner June 28, 2023 21:05
@philknows philknows changed the title Release v1.9.1 chore: release v1.9.1 Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a6a142e Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 474.23 us/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 44.609 us/op
BLS verify - blst-native 1.2071 ms/op
BLS verifyMultipleSignatures 3 - blst-native 2.4947 ms/op
BLS verifyMultipleSignatures 8 - blst-native 5.2988 ms/op
BLS verifyMultipleSignatures 32 - blst-native 19.228 ms/op
BLS aggregatePubkeys 32 - blst-native 25.844 us/op
BLS aggregatePubkeys 128 - blst-native 100.28 us/op
getAttestationsForBlock 56.270 ms/op
isKnown best case - 1 super set check 257.00 ns/op
isKnown normal case - 2 super set checks 255.00 ns/op
isKnown worse case - 16 super set checks 255.00 ns/op
CheckpointStateCache - add get delete 5.1030 us/op
validate gossip signedAggregateAndProof - struct 2.7885 ms/op
validate gossip attestation - struct 1.3163 ms/op
pickEth1Vote - no votes 1.2335 ms/op
pickEth1Vote - max votes 8.3222 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.3552 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 12.854 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 626.71 us/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.5180 ms/op
bytes32 toHexString 479.00 ns/op
bytes32 Buffer.toString(hex) 341.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 539.00 ns/op
bytes32 Buffer.toString(hex) + 0x 348.00 ns/op
Object access 1 prop 0.16000 ns/op
Map access 1 prop 0.15600 ns/op
Object get x1000 6.9460 ns/op
Map get x1000 0.60500 ns/op
Object set x1000 51.692 ns/op
Map set x1000 43.484 ns/op
Return object 10000 times 0.23500 ns/op
Throw Error 10000 times 4.2036 us/op
fastMsgIdFn sha256 / 200 bytes 3.4570 us/op
fastMsgIdFn h32 xxhash / 200 bytes 289.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 401.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 11.637 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 418.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 490.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 103.31 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 1.9540 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.4130 us/op
enrSubnets - fastDeserialize 64 bits 1.3090 us/op
enrSubnets - ssz BitVector 64 bits 489.00 ns/op
enrSubnets - fastDeserialize 4 bits 185.00 ns/op
enrSubnets - ssz BitVector 4 bits 509.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 115.22 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 131.76 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 179.89 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 323.29 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 368.23 us/op
array of 16000 items push then shift 1.6688 us/op
LinkedList of 16000 items push then shift 8.8680 ns/op
array of 16000 items push then pop 98.596 ns/op
LinkedList of 16000 items push then pop 8.6390 ns/op
array of 24000 items push then shift 2.3658 us/op
LinkedList of 24000 items push then shift 8.8450 ns/op
array of 24000 items push then pop 76.791 ns/op
LinkedList of 24000 items push then pop 8.8240 ns/op
intersect bitArray bitLen 8 13.383 ns/op
intersect array and set length 8 81.090 ns/op
intersect bitArray bitLen 128 43.879 ns/op
intersect array and set length 128 1.0636 us/op
Buffer.concat 32 items 2.9110 us/op
Uint8Array.set 32 items 2.1870 us/op
transfer serialized Status (84 B) 2.0220 us/op
copy serialized Status (84 B) 1.7120 us/op
transfer serialized SignedVoluntaryExit (112 B) 2.1350 us/op
copy serialized SignedVoluntaryExit (112 B) 1.7220 us/op
transfer serialized ProposerSlashing (416 B) 2.2150 us/op
copy serialized ProposerSlashing (416 B) 2.0700 us/op
transfer serialized Attestation (485 B) 2.2860 us/op
copy serialized Attestation (485 B) 2.3420 us/op
transfer serialized AttesterSlashing (33232 B) 2.4110 us/op
copy serialized AttesterSlashing (33232 B) 5.5130 us/op
transfer serialized Small SignedBeaconBlock (128000 B) 2.7410 us/op
copy serialized Small SignedBeaconBlock (128000 B) 13.664 us/op
transfer serialized Avg SignedBeaconBlock (200000 B) 3.0210 us/op
copy serialized Avg SignedBeaconBlock (200000 B) 65.068 us/op
transfer serialized BlobsSidecar (524380 B) 3.1380 us/op
copy serialized BlobsSidecar (524380 B) 150.44 us/op
transfer serialized Big SignedBeaconBlock (1000000 B) 3.3700 us/op
copy serialized Big SignedBeaconBlock (1000000 B) 239.50 us/op
pass gossip attestations to forkchoice per slot 2.6618 ms/op
forkChoice updateHead vc 100000 bc 64 eq 0 2.0876 ms/op
forkChoice updateHead vc 600000 bc 64 eq 0 11.395 ms/op
forkChoice updateHead vc 1000000 bc 64 eq 0 21.817 ms/op
forkChoice updateHead vc 600000 bc 320 eq 0 16.653 ms/op
forkChoice updateHead vc 600000 bc 1200 eq 0 78.847 ms/op
forkChoice updateHead vc 600000 bc 64 eq 1000 20.380 ms/op
forkChoice updateHead vc 600000 bc 64 eq 10000 22.830 ms/op
forkChoice updateHead vc 600000 bc 64 eq 300000 30.878 ms/op
computeDeltas 3.7306 ms/op
computeProposerBoostScoreFromBalances 1.7651 ms/op
altair processAttestation - 250000 vs - 7PWei normalcase 2.1225 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 3.2565 ms/op
altair processAttestation - setStatus - 1/6 committees join 138.97 us/op
altair processAttestation - setStatus - 1/3 committees join 272.45 us/op
altair processAttestation - setStatus - 1/2 committees join 368.40 us/op
altair processAttestation - setStatus - 2/3 committees join 454.30 us/op
altair processAttestation - setStatus - 4/5 committees join 644.00 us/op
altair processAttestation - setStatus - 100% committees join 755.14 us/op
altair processBlock - 250000 vs - 7PWei normalcase 19.016 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 25.990 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 52.926 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 67.208 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9932 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 28.030 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 473.26 us/op
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 6.3020 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 19.081 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.0990 us/op
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.1110 us/op
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 73.629 us/op
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 592.03 us/op
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 877.83 us/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 832.83 us/op
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.2612 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5868 ms/op
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.8605 ms/op
Tree 40 250000 create 311.56 ms/op
Tree 40 250000 get(125000) 181.44 ns/op
Tree 40 250000 set(125000) 937.29 ns/op
Tree 40 250000 toArray() 16.944 ms/op
Tree 40 250000 iterate all - toArray() + loop 18.192 ms/op
Tree 40 250000 iterate all - get(i) 65.625 ms/op
MutableVector 250000 create 9.8745 ms/op
MutableVector 250000 get(125000) 6.3020 ns/op
MutableVector 250000 set(125000) 244.72 ns/op
MutableVector 250000 toArray() 2.7349 ms/op
MutableVector 250000 iterate all - toArray() + loop 2.8444 ms/op
MutableVector 250000 iterate all - get(i) 1.4993 ms/op
Array 250000 create 2.4960 ms/op
Array 250000 clone - spread 1.1343 ms/op
Array 250000 get(125000) 0.56700 ns/op
Array 250000 set(125000) 0.64100 ns/op
Array 250000 iterate all - loop 81.292 us/op
effectiveBalanceIncrements clone Uint8Array 300000 28.972 us/op
effectiveBalanceIncrements clone MutableVector 300000 357.00 ns/op
effectiveBalanceIncrements rw all Uint8Array 300000 166.37 us/op
effectiveBalanceIncrements rw all MutableVector 300000 78.561 ms/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 110.29 ms/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 31.449 ms/op
altair processEpoch - mainnet_e81889 326.40 ms/op
mainnet_e81889 - altair beforeProcessEpoch 66.317 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 16.413 us/op
mainnet_e81889 - altair processInactivityUpdates 5.2479 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 67.592 ms/op
mainnet_e81889 - altair processRegistryUpdates 3.1160 us/op
mainnet_e81889 - altair processSlashings 460.00 ns/op
mainnet_e81889 - altair processEth1DataReset 512.00 ns/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2274 ms/op
mainnet_e81889 - altair processSlashingsReset 4.6450 us/op
mainnet_e81889 - altair processRandaoMixesReset 4.5880 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 764.00 ns/op
mainnet_e81889 - altair processParticipationFlagUpdates 2.7390 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 709.00 ns/op
mainnet_e81889 - altair afterProcessEpoch 122.78 ms/op
phase0 processEpoch - mainnet_e58758 359.21 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 139.20 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 16.880 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 63.194 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 7.7420 us/op
mainnet_e58758 - phase0 processSlashings 495.00 ns/op
mainnet_e58758 - phase0 processEth1DataReset 508.00 ns/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 940.41 us/op
mainnet_e58758 - phase0 processSlashingsReset 3.5450 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 5.1160 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 783.00 ns/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.9960 us/op
mainnet_e58758 - phase0 afterProcessEpoch 93.453 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2148 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5208 ms/op
altair processInactivityUpdates - 250000 normalcase 25.251 ms/op
altair processInactivityUpdates - 250000 worstcase 26.729 ms/op
phase0 processRegistryUpdates - 250000 normalcase 6.8000 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 237.61 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 128.83 ms/op
altair processRewardsAndPenalties - 250000 normalcase 65.961 ms/op
altair processRewardsAndPenalties - 250000 worstcase 70.894 ms/op
phase0 getAttestationDeltas - 250000 normalcase 6.6761 ms/op
phase0 getAttestationDeltas - 250000 worstcase 6.6464 ms/op
phase0 processSlashings - 250000 worstcase 3.4959 ms/op
altair processSyncCommitteeUpdates - 250000 171.88 ms/op
BeaconState.hashTreeRoot - No change 274.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 51.548 us/op
BeaconState.hashTreeRoot - 32 full validator 507.44 us/op
BeaconState.hashTreeRoot - 512 full validator 5.4630 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.306 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 910.85 us/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 11.198 ms/op
BeaconState.hashTreeRoot - 1 balances 48.408 us/op
BeaconState.hashTreeRoot - 32 balances 457.59 us/op
BeaconState.hashTreeRoot - 512 balances 4.3803 ms/op
BeaconState.hashTreeRoot - 250000 balances 71.960 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 14.834 us/op
regular array get 100000 times 32.005 us/op
wrappedArray get 100000 times 31.966 us/op
arrayWithProxy get 100000 times 15.543 ms/op
ssz.Root.equals 528.00 ns/op
byteArrayEquals 517.00 ns/op
shuffle list - 16384 els 6.6444 ms/op
shuffle list - 250000 els 97.482 ms/op
processSlot - 1 slots 8.3280 us/op
processSlot - 32 slots 1.3208 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 37.483 ms/op
getCommitteeAssignments - req 1 vs - 250000 vc 2.8449 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 4.0275 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3636 ms/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.5300 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 763.80 ns/op
computeProposers - vc 250000 10.274 ms/op
computeEpochShuffling - vc 250000 100.10 ms/op
getNextSyncCommittee - vc 250000 169.77 ms/op
computeSigningRoot for AttestationData 13.550 us/op
hash AttestationData serialized data then Buffer.toString(base64) 2.3901 us/op
toHexString serialized data 1.0391 us/op
Buffer.toString(base64) 310.68 ns/op

by benchmarkbot/action

twoeths
twoeths previously approved these changes Jun 29, 2023
@twoeths twoeths marked this pull request as draft June 29, 2023 01:43
@philknows philknows marked this pull request as ready for review June 29, 2023 02:10
@twoeths twoeths marked this pull request as draft June 29, 2023 02:12
* fix: add setTimeout to onGossipsubMessage and onValidationResult

* chore: more comments
@philknows philknows marked this pull request as ready for review June 30, 2023 17:16
@philknows philknows merged commit 6845eec into stable Jun 30, 2023
@philknows philknows deleted the rc/v1.9.1 branch June 30, 2023 18:08
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants