-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: freeze voluntary exit signature fork domain to Capella version from deneb fork onwards #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Doesn't the EIP say to lock the fork to Capella? |
oops yes, that also resolves my confusion of how capella signed exits will be valid in deneb |
g11tech
changed the title
feat: freeze voluntary exit signature fork domain to Deneb
feat: freeze voluntary exit signature fork domain to Capella
Jun 24, 2023
g11tech
changed the title
feat: freeze voluntary exit signature fork domain to Capella
feat: freeze voluntary exit signature fork domain to Capella version from deneb fork onwards
Jun 24, 2023
twoeths
reviewed
Jun 26, 2023
twoeths
approved these changes
Jun 28, 2023
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref
NOTE:
This PR skips some spec tests as they test voluntary exits on deneb domain fork. These skips will be removed with the new spec version update for which a few other PRs are pending.