Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: assert yarn prints no warnings #5565

Merged
merged 3 commits into from
Jun 27, 2023
Merged

ci: assert yarn prints no warnings #5565

merged 3 commits into from
Jun 27, 2023

Conversation

dapplion
Copy link
Contributor

Motivation

Description

yarn does not offer a clean way to trigger those warnings. From yarnpkg/yarn#4594 and some local tests --check-files seem to work fine, but I haven't tested on CI before opening this PR

Closes #5115

@dapplion dapplion requested a review from a team as a code owner May 29, 2023 08:25
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: b56193b Previous: 9ba6d54 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 970.16 us/op 598.14 us/op 1.62
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 46.450 us/op 50.998 us/op 0.91
BLS verify - blst-native 1.2385 ms/op 1.2601 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 2.5027 ms/op 2.5706 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.2844 ms/op 5.5661 ms/op 0.95
BLS verifyMultipleSignatures 32 - blst-native 19.521 ms/op 20.022 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 25.931 us/op 26.628 us/op 0.97
BLS aggregatePubkeys 128 - blst-native 101.29 us/op 104.36 us/op 0.97
getAttestationsForBlock 55.796 ms/op 56.079 ms/op 0.99
isKnown best case - 1 super set check 248.00 ns/op 253.00 ns/op 0.98
isKnown normal case - 2 super set checks 242.00 ns/op 253.00 ns/op 0.96
isKnown worse case - 16 super set checks 242.00 ns/op 254.00 ns/op 0.95
CheckpointStateCache - add get delete 5.5250 us/op 5.9740 us/op 0.92
validate gossip signedAggregateAndProof - struct 2.8696 ms/op 3.6064 ms/op 0.80
validate gossip attestation - struct 1.3384 ms/op 1.4528 ms/op 0.92
pickEth1Vote - no votes 1.2984 ms/op 1.4908 ms/op 0.87
pickEth1Vote - max votes 10.808 ms/op 13.895 ms/op 0.78
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.7734 ms/op 9.9244 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.112 ms/op 15.520 ms/op 0.97
pickEth1Vote - Eth1Data fastSerialize value x2048 675.26 us/op 759.46 us/op 0.89
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.2865 ms/op 5.7103 ms/op 1.28
bytes32 toHexString 502.00 ns/op 649.00 ns/op 0.77
bytes32 Buffer.toString(hex) 358.00 ns/op 397.00 ns/op 0.90
bytes32 Buffer.toString(hex) from Uint8Array 575.00 ns/op 633.00 ns/op 0.91
bytes32 Buffer.toString(hex) + 0x 362.00 ns/op 468.00 ns/op 0.77
Object access 1 prop 0.16500 ns/op 0.21700 ns/op 0.76
Map access 1 prop 0.15700 ns/op 0.17300 ns/op 0.91
Object get x1000 6.6210 ns/op 7.2240 ns/op 0.92
Map get x1000 0.63000 ns/op 0.66000 ns/op 0.95
Object set x1000 53.136 ns/op 68.605 ns/op 0.77
Map set x1000 43.799 ns/op 52.048 ns/op 0.84
Return object 10000 times 0.23880 ns/op 0.26120 ns/op 0.91
Throw Error 10000 times 4.1764 us/op 4.4593 us/op 0.94
fastMsgIdFn sha256 / 200 bytes 3.4370 us/op 3.6420 us/op 0.94
fastMsgIdFn h32 xxhash / 200 bytes 279.00 ns/op 330.00 ns/op 0.85
fastMsgIdFn h64 xxhash / 200 bytes 402.00 ns/op 477.00 ns/op 0.84
fastMsgIdFn sha256 / 1000 bytes 11.592 us/op 12.255 us/op 0.95
fastMsgIdFn h32 xxhash / 1000 bytes 406.00 ns/op 459.00 ns/op 0.88
fastMsgIdFn h64 xxhash / 1000 bytes 477.00 ns/op 549.00 ns/op 0.87
fastMsgIdFn sha256 / 10000 bytes 103.30 us/op 109.21 us/op 0.95
fastMsgIdFn h32 xxhash / 10000 bytes 1.9410 us/op 2.0820 us/op 0.93
fastMsgIdFn h64 xxhash / 10000 bytes 1.3840 us/op 1.5050 us/op 0.92
enrSubnets - fastDeserialize 64 bits 1.2940 us/op 1.6800 us/op 0.77
enrSubnets - ssz BitVector 64 bits 484.00 ns/op 637.00 ns/op 0.76
enrSubnets - fastDeserialize 4 bits 176.00 ns/op 217.00 ns/op 0.81
enrSubnets - ssz BitVector 4 bits 498.00 ns/op 693.00 ns/op 0.72
prioritizePeers score -10:0 att 32-0.1 sync 2-0 109.25 us/op 121.00 us/op 0.90
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 156.45 us/op 167.48 us/op 0.93
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 168.06 us/op 194.59 us/op 0.86
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 378.61 us/op 373.89 us/op 1.01
prioritizePeers score 0:0 att 64-1 sync 4-1 391.83 us/op 444.22 us/op 0.88
array of 16000 items push then shift 1.6912 us/op 1.7709 us/op 0.95
LinkedList of 16000 items push then shift 9.0720 ns/op 9.7300 ns/op 0.93
array of 16000 items push then pop 95.472 ns/op 116.37 ns/op 0.82
LinkedList of 16000 items push then pop 8.7140 ns/op 9.6290 ns/op 0.90
array of 24000 items push then shift 2.4118 us/op 2.4808 us/op 0.97
LinkedList of 24000 items push then shift 8.9920 ns/op 9.4760 ns/op 0.95
array of 24000 items push then pop 77.070 ns/op 95.101 ns/op 0.81
LinkedList of 24000 items push then pop 8.7730 ns/op 9.1670 ns/op 0.96
intersect bitArray bitLen 8 13.659 ns/op 13.897 ns/op 0.98
intersect array and set length 8 78.803 ns/op 107.78 ns/op 0.73
intersect bitArray bitLen 128 45.296 ns/op 49.443 ns/op 0.92
intersect array and set length 128 1.0581 us/op 1.4485 us/op 0.73
Buffer.concat 32 items 2.6330 us/op 3.9780 us/op 0.66
Uint8Array.set 32 items 2.1430 us/op 3.4900 us/op 0.61
transfer serialized Status (84 B) 2.0900 us/op 2.6080 us/op 0.80
copy serialized Status (84 B) 1.6920 us/op 2.0390 us/op 0.83
transfer serialized SignedVoluntaryExit (112 B) 2.1200 us/op 2.5490 us/op 0.83
copy serialized SignedVoluntaryExit (112 B) 1.8220 us/op 2.1690 us/op 0.84
transfer serialized ProposerSlashing (416 B) 2.5530 us/op 3.1220 us/op 0.82
copy serialized ProposerSlashing (416 B) 3.2870 us/op 3.1860 us/op 1.03
transfer serialized Attestation (485 B) 3.4840 us/op 3.7920 us/op 0.92
copy serialized Attestation (485 B) 2.2700 us/op 3.1800 us/op 0.71
transfer serialized AttesterSlashing (33232 B) 2.4220 us/op 4.2140 us/op 0.57
copy serialized AttesterSlashing (33232 B) 5.4460 us/op 11.788 us/op 0.46
transfer serialized Small SignedBeaconBlock (128000 B) 2.5430 us/op 4.7580 us/op 0.53
copy serialized Small SignedBeaconBlock (128000 B) 19.440 us/op 32.179 us/op 0.60
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2210 us/op 4.8220 us/op 0.67
copy serialized Avg SignedBeaconBlock (200000 B) 24.874 us/op 50.951 us/op 0.49
transfer serialized BlobsSidecar (524380 B) 3.2400 us/op 6.0740 us/op 0.53
copy serialized BlobsSidecar (524380 B) 109.06 us/op 119.61 us/op 0.91
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2330 us/op 5.1870 us/op 0.62
copy serialized Big SignedBeaconBlock (1000000 B) 250.41 us/op 397.42 us/op 0.63
pass gossip attestations to forkchoice per slot 2.9452 ms/op 4.0189 ms/op 0.73
forkChoice updateHead vc 100000 bc 64 eq 0 2.1482 ms/op 2.3832 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 0 15.295 ms/op 14.577 ms/op 1.05
forkChoice updateHead vc 1000000 bc 64 eq 0 19.377 ms/op 33.552 ms/op 0.58
forkChoice updateHead vc 600000 bc 320 eq 0 16.949 ms/op 21.171 ms/op 0.80
forkChoice updateHead vc 600000 bc 1200 eq 0 87.858 ms/op 97.344 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 1000 26.210 ms/op 23.058 ms/op 1.14
forkChoice updateHead vc 600000 bc 64 eq 10000 26.932 ms/op 24.216 ms/op 1.11
forkChoice updateHead vc 600000 bc 64 eq 300000 35.825 ms/op 40.277 ms/op 0.89
computeDeltas 3.0333 ms/op 4.2496 ms/op 0.71
computeProposerBoostScoreFromBalances 1.8039 ms/op 1.9009 ms/op 0.95
altair processAttestation - 250000 vs - 7PWei normalcase 2.3471 ms/op 3.6641 ms/op 0.64
altair processAttestation - 250000 vs - 7PWei worstcase 3.6414 ms/op 4.8098 ms/op 0.76
altair processAttestation - setStatus - 1/6 committees join 149.45 us/op 147.56 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 286.72 us/op 305.43 us/op 0.94
altair processAttestation - setStatus - 1/2 committees join 379.13 us/op 396.49 us/op 0.96
altair processAttestation - setStatus - 2/3 committees join 465.39 us/op 504.46 us/op 0.92
altair processAttestation - setStatus - 4/5 committees join 686.23 us/op 722.87 us/op 0.95
altair processAttestation - setStatus - 100% committees join 781.53 us/op 822.10 us/op 0.95
altair processBlock - 250000 vs - 7PWei normalcase 17.995 ms/op 20.526 ms/op 0.88
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.341 ms/op 36.892 ms/op 0.77
altair processBlock - 250000 vs - 7PWei worstcase 58.147 ms/op 67.054 ms/op 0.87
altair processBlock - 250000 vs - 7PWei worstcase hashState 75.010 ms/op 86.530 ms/op 0.87
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3013 ms/op 3.6405 ms/op 0.63
phase0 processBlock - 250000 vs - 7PWei worstcase 31.043 ms/op 38.479 ms/op 0.81
altair processEth1Data - 250000 vs - 7PWei normalcase 577.25 us/op 816.17 us/op 0.71
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.6410 us/op 12.650 us/op 0.76
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 29.849 us/op 36.905 us/op 0.81
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 14.150 us/op 15.468 us/op 0.91
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.2380 us/op 11.227 us/op 0.64
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 107.10 us/op 126.94 us/op 0.84
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 668.50 us/op 831.86 us/op 0.80
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 857.23 us/op 1.0099 ms/op 0.85
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 881.46 us/op 1.0050 ms/op 0.88
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4143 ms/op 3.8270 ms/op 0.63
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5689 ms/op 2.2662 ms/op 0.69
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.9763 ms/op 6.1401 ms/op 0.65
Tree 40 250000 create 364.34 ms/op 527.41 ms/op 0.69
Tree 40 250000 get(125000) 195.67 ns/op 206.94 ns/op 0.95
Tree 40 250000 set(125000) 1.0683 us/op 1.1804 us/op 0.91
Tree 40 250000 toArray() 22.875 ms/op 24.599 ms/op 0.93
Tree 40 250000 iterate all - toArray() + loop 25.210 ms/op 30.078 ms/op 0.84
Tree 40 250000 iterate all - get(i) 82.762 ms/op 108.53 ms/op 0.76
MutableVector 250000 create 12.914 ms/op 14.091 ms/op 0.92
MutableVector 250000 get(125000) 6.8170 ns/op 7.1280 ns/op 0.96
MutableVector 250000 set(125000) 327.90 ns/op 486.68 ns/op 0.67
MutableVector 250000 toArray() 4.0595 ms/op 5.1404 ms/op 0.79
MutableVector 250000 iterate all - toArray() + loop 4.0076 ms/op 4.3133 ms/op 0.93
MutableVector 250000 iterate all - get(i) 1.6435 ms/op 1.6083 ms/op 1.02
Array 250000 create 3.4808 ms/op 4.5285 ms/op 0.77
Array 250000 clone - spread 1.2760 ms/op 1.5935 ms/op 0.80
Array 250000 get(125000) 0.65100 ns/op 0.69800 ns/op 0.93
Array 250000 set(125000) 0.69100 ns/op 0.92700 ns/op 0.75
Array 250000 iterate all - loop 86.416 us/op 100.96 us/op 0.86
effectiveBalanceIncrements clone Uint8Array 300000 48.748 us/op 77.267 us/op 0.63
effectiveBalanceIncrements clone MutableVector 300000 415.00 ns/op 566.00 ns/op 0.73
effectiveBalanceIncrements rw all Uint8Array 300000 183.30 us/op 203.91 us/op 0.90
effectiveBalanceIncrements rw all MutableVector 300000 118.15 ms/op 152.38 ms/op 0.78
phase0 afterProcessEpoch - 250000 vs - 7PWei 126.06 ms/op 128.99 ms/op 0.98
phase0 beforeProcessEpoch - 250000 vs - 7PWei 38.539 ms/op 66.636 ms/op 0.58
altair processEpoch - mainnet_e81889 401.15 ms/op 421.19 ms/op 0.95
mainnet_e81889 - altair beforeProcessEpoch 93.008 ms/op 112.91 ms/op 0.82
mainnet_e81889 - altair processJustificationAndFinalization 22.356 us/op 32.252 us/op 0.69
mainnet_e81889 - altair processInactivityUpdates 6.0058 ms/op 10.581 ms/op 0.57
mainnet_e81889 - altair processRewardsAndPenalties 76.269 ms/op 93.606 ms/op 0.81
mainnet_e81889 - altair processRegistryUpdates 3.8210 us/op 7.6830 us/op 0.50
mainnet_e81889 - altair processSlashings 703.00 ns/op 1.4500 us/op 0.48
mainnet_e81889 - altair processEth1DataReset 637.00 ns/op 1.3150 us/op 0.48
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2950 ms/op 1.6411 ms/op 0.79
mainnet_e81889 - altair processSlashingsReset 5.2960 us/op 8.4670 us/op 0.63
mainnet_e81889 - altair processRandaoMixesReset 10.147 us/op 6.5150 us/op 1.56
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2800 us/op 2.1210 us/op 0.60
mainnet_e81889 - altair processParticipationFlagUpdates 3.4040 us/op 7.1690 us/op 0.47
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0720 us/op 2.0000 us/op 0.54
mainnet_e81889 - altair afterProcessEpoch 132.12 ms/op 142.82 ms/op 0.93
phase0 processEpoch - mainnet_e58758 421.54 ms/op 506.51 ms/op 0.83
mainnet_e58758 - phase0 beforeProcessEpoch 168.10 ms/op 231.08 ms/op 0.73
mainnet_e58758 - phase0 processJustificationAndFinalization 26.758 us/op 33.730 us/op 0.79
mainnet_e58758 - phase0 processRewardsAndPenalties 75.222 ms/op 70.581 ms/op 1.07
mainnet_e58758 - phase0 processRegistryUpdates 11.561 us/op 19.997 us/op 0.58
mainnet_e58758 - phase0 processSlashings 927.00 ns/op 1.3760 us/op 0.67
mainnet_e58758 - phase0 processEth1DataReset 1.0630 us/op 1.0570 us/op 1.01
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0602 ms/op 1.2164 ms/op 0.87
mainnet_e58758 - phase0 processSlashingsReset 4.4750 us/op 8.5800 us/op 0.52
mainnet_e58758 - phase0 processRandaoMixesReset 6.7420 us/op 9.6570 us/op 0.70
mainnet_e58758 - phase0 processHistoricalRootsUpdate 731.00 ns/op 1.9670 us/op 0.37
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.7220 us/op 9.4820 us/op 0.50
mainnet_e58758 - phase0 afterProcessEpoch 101.15 ms/op 117.31 ms/op 0.86
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3471 ms/op 2.1490 ms/op 0.63
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6866 ms/op 2.4566 ms/op 0.69
altair processInactivityUpdates - 250000 normalcase 24.840 ms/op 29.474 ms/op 0.84
altair processInactivityUpdates - 250000 worstcase 22.917 ms/op 36.723 ms/op 0.62
phase0 processRegistryUpdates - 250000 normalcase 7.7020 us/op 14.794 us/op 0.52
phase0 processRegistryUpdates - 250000 badcase_full_deposits 287.14 us/op 378.25 us/op 0.76
phase0 processRegistryUpdates - 250000 worstcase 0.5 132.13 ms/op 137.57 ms/op 0.96
altair processRewardsAndPenalties - 250000 normalcase 69.373 ms/op 66.564 ms/op 1.04
altair processRewardsAndPenalties - 250000 worstcase 70.965 ms/op 69.285 ms/op 1.02
phase0 getAttestationDeltas - 250000 normalcase 10.628 ms/op 7.6266 ms/op 1.39
phase0 getAttestationDeltas - 250000 worstcase 8.4614 ms/op 9.8486 ms/op 0.86
phase0 processSlashings - 250000 worstcase 3.6779 ms/op 4.4497 ms/op 0.83
altair processSyncCommitteeUpdates - 250000 189.12 ms/op 209.97 ms/op 0.90
BeaconState.hashTreeRoot - No change 335.00 ns/op 295.00 ns/op 1.14
BeaconState.hashTreeRoot - 1 full validator 53.378 us/op 54.201 us/op 0.98
BeaconState.hashTreeRoot - 32 full validator 576.10 us/op 558.85 us/op 1.03
BeaconState.hashTreeRoot - 512 full validator 5.4424 ms/op 5.4481 ms/op 1.00
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 68.982 us/op 70.888 us/op 0.97
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 940.01 us/op 944.41 us/op 1.00
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.849 ms/op 13.820 ms/op 1.00
BeaconState.hashTreeRoot - 1 balances 54.304 us/op 53.823 us/op 1.01
BeaconState.hashTreeRoot - 32 balances 505.53 us/op 489.59 us/op 1.03
BeaconState.hashTreeRoot - 512 balances 4.5674 ms/op 4.9674 ms/op 0.92
BeaconState.hashTreeRoot - 250000 balances 72.478 ms/op 82.143 ms/op 0.88
aggregationBits - 2048 els - zipIndexesInBitList 18.534 us/op 28.919 us/op 0.64
regular array get 100000 times 45.733 us/op 45.415 us/op 1.01
wrappedArray get 100000 times 34.245 us/op 39.597 us/op 0.86
arrayWithProxy get 100000 times 17.296 ms/op 16.677 ms/op 1.04
ssz.Root.equals 589.00 ns/op 662.00 ns/op 0.89
byteArrayEquals 571.00 ns/op 703.00 ns/op 0.81
shuffle list - 16384 els 7.1824 ms/op 7.3887 ms/op 0.97
shuffle list - 250000 els 104.51 ms/op 108.74 ms/op 0.96
processSlot - 1 slots 9.6880 us/op 10.763 us/op 0.90
processSlot - 32 slots 1.4464 ms/op 1.6514 ms/op 0.88
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 37.851 ms/op 37.544 ms/op 1.01
getCommitteeAssignments - req 1 vs - 250000 vc 3.8931 ms/op 3.1365 ms/op 1.24
getCommitteeAssignments - req 100 vs - 250000 vc 4.7007 ms/op 4.5288 ms/op 1.04
getCommitteeAssignments - req 1000 vs - 250000 vc 5.1493 ms/op 4.8522 ms/op 1.06
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.6000 ns/op 5.8400 ns/op 0.96
state getBlockRootAtSlot - 250000 vs - 7PWei 893.54 ns/op 1.0261 us/op 0.87
computeProposers - vc 250000 12.146 ms/op 12.254 ms/op 0.99
computeEpochShuffling - vc 250000 116.44 ms/op 121.43 ms/op 0.96
getNextSyncCommittee - vc 250000 201.26 ms/op 206.67 ms/op 0.97
computeSigningRoot for AttestationData 15.078 us/op 16.045 us/op 0.94
hash AttestationData serialized data then Buffer.toString(base64) 2.6507 us/op 2.6923 us/op 0.98
toHexString serialized data 1.3706 us/op 1.5498 us/op 0.88
Buffer.toString(base64) 392.25 ns/op 462.98 ns/op 0.85

by benchmarkbot/action

@nflaig nflaig changed the title Assert in CI yarn prints no warnings ci: assert yarn prints no warnings May 29, 2023
@nflaig
Copy link
Member

nflaig commented May 29, 2023

Looks good but the job succeeds either way are we fine with this behavior for now?

I am not sure we can fix all warnings, most of unmet peer dep warnings were resolved here

@dapplion
Copy link
Contributor Author

Hmm the script should not succeed actually, there are warnings now. Does yarn emit warnings via stdout or stderr?

@nflaig
Copy link
Member

nflaig commented May 29, 2023

This is the output of the job

Run scripts/assert_no_yarn_warnings.sh
yarn install v1.22.19 [1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... [[4](https://github.com/ChainSafe/lodestar/actions/runs/5110027191/jobs/9185457601?pr=5565#step:9:5)/[5](https://github.com/ChainSafe/lodestar/actions/runs/5110027191/jobs/9185457601?pr=5565#step:9:6)] Linking dependencies... warning " > @lodestar/reqresp@1.8.0" has unmet peer dependency "libp2p@~0.42.2". warning "workspace-aggregator-fce28fe8-89b4-4e7e-9236-918f9035bc21 > @lodestar/beacon-node > @chainsafe/bls@7.1.1" has unmet peer dependency "@chainsafe/blst@^0.2.4". warning "workspace-aggregator-fce28fe8-89b4-4e7e-9236-918f9035bc21 > @lodestar/beacon-node > prometheus-gc-stats@0.6.4" has incorrect peer dependency "prom-client@>= 10 <= 12". warning "workspace-aggregator-fce28fe8-89b4-4e7e-9236-918f9035bc21 > @lodestar/beacon-node > @multiformats/multiaddr > dns-over-http-resolver > native-fetch@4.0.2" has unmet peer dependency "undici@*". [5/5] Building fresh packages... Done in 71.45s.
There were warnings in yarn install --check-files

The script works but we are still exiting with code 0. Probably just have to do exit 1

@dapplion
Copy link
Contributor Author

dapplion commented Jun 1, 2023

Oh lol, forgot that line

@nflaig nflaig mentioned this pull request Jun 26, 2023
Merged
@nflaig nflaig merged commit 46ebb53 into unstable Jun 27, 2023
@nflaig nflaig deleted the dapplion/yarn-warning branch June 27, 2023 16:46
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

@nflaig nflaig mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI step to check no warning of unmet dependency
3 participants
@dapplion @nflaig @wemeetagain