Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update libp2p to 0.45.x #5506

Merged
merged 16 commits into from
Jul 5, 2023
Merged

deps: update libp2p to 0.45.x #5506

merged 16 commits into from
Jul 5, 2023

Conversation

wemeetagain
Copy link
Member

No description provided.

@wemeetagain wemeetagain requested a review from a team as a code owner May 17, 2023 22:15
@wemeetagain wemeetagain changed the title deps: update libp2p deps: update libp2p to 0.45.0 May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: a1d6921 Previous: 9ea69ef Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 510.54 us/op 490.26 us/op 1.04
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 46.493 us/op 46.214 us/op 1.01
BLS verify - blst-native 1.2197 ms/op 1.2314 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.4925 ms/op 2.5078 ms/op 0.99
BLS verifyMultipleSignatures 8 - blst-native 5.3653 ms/op 5.3846 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 19.451 ms/op 19.435 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 25.782 us/op 26.304 us/op 0.98
BLS aggregatePubkeys 128 - blst-native 101.75 us/op 101.44 us/op 1.00
getAttestationsForBlock 51.274 ms/op 51.511 ms/op 1.00
isKnown best case - 1 super set check 267.00 ns/op 252.00 ns/op 1.06
isKnown normal case - 2 super set checks 255.00 ns/op 250.00 ns/op 1.02
isKnown worse case - 16 super set checks 255.00 ns/op 248.00 ns/op 1.03
CheckpointStateCache - add get delete 5.2270 us/op 5.2310 us/op 1.00
validate gossip signedAggregateAndProof - struct 2.8144 ms/op 2.8307 ms/op 0.99
validate gossip attestation - struct 1.3408 ms/op 1.3488 ms/op 0.99
pickEth1Vote - no votes 1.2684 ms/op 1.2533 ms/op 1.01
pickEth1Vote - max votes 8.7046 ms/op 8.5778 ms/op 1.01
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.5562 ms/op 8.6072 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.684 ms/op 13.727 ms/op 1.00
pickEth1Vote - Eth1Data fastSerialize value x2048 680.14 us/op 660.50 us/op 1.03
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.5924 ms/op 4.5497 ms/op 1.01
bytes32 toHexString 494.00 ns/op 501.00 ns/op 0.99
bytes32 Buffer.toString(hex) 347.00 ns/op 355.00 ns/op 0.98
bytes32 Buffer.toString(hex) from Uint8Array 568.00 ns/op 561.00 ns/op 1.01
bytes32 Buffer.toString(hex) + 0x 350.00 ns/op 359.00 ns/op 0.97
Object access 1 prop 0.16900 ns/op 0.16700 ns/op 1.01
Map access 1 prop 0.16000 ns/op 0.15900 ns/op 1.01
Object get x1000 6.5220 ns/op 6.6650 ns/op 0.98
Map get x1000 0.57000 ns/op 0.53800 ns/op 1.06
Object set x1000 60.391 ns/op 54.266 ns/op 1.11
Map set x1000 46.881 ns/op 43.988 ns/op 1.07
Return object 10000 times 0.24320 ns/op 0.25020 ns/op 0.97
Throw Error 10000 times 4.4172 us/op 4.2675 us/op 1.04
fastMsgIdFn sha256 / 200 bytes 3.5850 us/op 3.5760 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 285.00 ns/op 285.00 ns/op 1.00
fastMsgIdFn h64 xxhash / 200 bytes 429.00 ns/op 398.00 ns/op 1.08
fastMsgIdFn sha256 / 1000 bytes 11.898 us/op 11.716 us/op 1.02
fastMsgIdFn h32 xxhash / 1000 bytes 415.00 ns/op 407.00 ns/op 1.02
fastMsgIdFn h64 xxhash / 1000 bytes 474.00 ns/op 440.00 ns/op 1.08
fastMsgIdFn sha256 / 10000 bytes 105.76 us/op 105.29 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.9670 us/op 1.9530 us/op 1.01
fastMsgIdFn h64 xxhash / 10000 bytes 1.4010 us/op 1.3820 us/op 1.01
enrSubnets - fastDeserialize 64 bits 1.3860 us/op 1.2870 us/op 1.08
enrSubnets - ssz BitVector 64 bits 503.00 ns/op 462.00 ns/op 1.09
enrSubnets - fastDeserialize 4 bits 177.00 ns/op 170.00 ns/op 1.04
enrSubnets - ssz BitVector 4 bits 494.00 ns/op 461.00 ns/op 1.07
prioritizePeers score -10:0 att 32-0.1 sync 2-0 108.32 us/op 109.06 us/op 0.99
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 142.40 us/op 138.43 us/op 1.03
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 173.64 us/op 180.73 us/op 0.96
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 316.91 us/op 316.47 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 380.56 us/op 416.31 us/op 0.91
array of 16000 items push then shift 1.6650 us/op 1.6613 us/op 1.00
LinkedList of 16000 items push then shift 8.8840 ns/op 8.8240 ns/op 1.01
array of 16000 items push then pop 86.401 ns/op 91.499 ns/op 0.94
LinkedList of 16000 items push then pop 8.6970 ns/op 8.4360 ns/op 1.03
array of 24000 items push then shift 2.3784 us/op 2.4493 us/op 0.97
LinkedList of 24000 items push then shift 9.0460 ns/op 8.9370 ns/op 1.01
array of 24000 items push then pop 81.091 ns/op 76.860 ns/op 1.06
LinkedList of 24000 items push then pop 8.7460 ns/op 8.6630 ns/op 1.01
intersect bitArray bitLen 8 13.343 ns/op 13.291 ns/op 1.00
intersect array and set length 8 81.110 ns/op 78.389 ns/op 1.03
intersect bitArray bitLen 128 44.893 ns/op 44.280 ns/op 1.01
intersect array and set length 128 1.1340 us/op 1.0817 us/op 1.05
Buffer.concat 32 items 2.9450 us/op 2.9000 us/op 1.02
Uint8Array.set 32 items 2.2150 us/op 2.4860 us/op 0.89
transfer serialized Status (84 B) 2.0040 us/op 2.0960 us/op 0.96
copy serialized Status (84 B) 1.7010 us/op 1.6540 us/op 1.03
transfer serialized SignedVoluntaryExit (112 B) 2.1530 us/op 2.0600 us/op 1.05
copy serialized SignedVoluntaryExit (112 B) 1.8080 us/op 1.7030 us/op 1.06
transfer serialized ProposerSlashing (416 B) 2.7320 us/op 3.0900 us/op 0.88
copy serialized ProposerSlashing (416 B) 2.0650 us/op 3.3380 us/op 0.62
transfer serialized Attestation (485 B) 2.4840 us/op 3.3040 us/op 0.75
copy serialized Attestation (485 B) 3.1600 us/op 2.3570 us/op 1.34
transfer serialized AttesterSlashing (33232 B) 3.2470 us/op 2.8820 us/op 1.13
copy serialized AttesterSlashing (33232 B) 6.8960 us/op 6.5850 us/op 1.05
transfer serialized Small SignedBeaconBlock (128000 B) 3.5270 us/op 3.2180 us/op 1.10
copy serialized Small SignedBeaconBlock (128000 B) 46.847 us/op 16.251 us/op 2.88
transfer serialized Avg SignedBeaconBlock (200000 B) 3.6780 us/op 3.9990 us/op 0.92
copy serialized Avg SignedBeaconBlock (200000 B) 59.753 us/op 71.120 us/op 0.84
transfer serialized BlobsSidecar (524380 B) 3.4230 us/op 3.5740 us/op 0.96
copy serialized BlobsSidecar (524380 B) 173.35 us/op 83.002 us/op 2.09
transfer serialized Big SignedBeaconBlock (1000000 B) 3.9260 us/op 3.4050 us/op 1.15
copy serialized Big SignedBeaconBlock (1000000 B) 304.69 us/op 261.74 us/op 1.16
pass gossip attestations to forkchoice per slot 2.7400 ms/op 2.7137 ms/op 1.01
forkChoice updateHead vc 100000 bc 64 eq 0 2.0875 ms/op 2.0905 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 0 11.533 ms/op 11.922 ms/op 0.97
forkChoice updateHead vc 1000000 bc 64 eq 0 22.233 ms/op 22.282 ms/op 1.00
forkChoice updateHead vc 600000 bc 320 eq 0 16.554 ms/op 16.844 ms/op 0.98
forkChoice updateHead vc 600000 bc 1200 eq 0 82.348 ms/op 83.381 ms/op 0.99
forkChoice updateHead vc 600000 bc 64 eq 1000 20.743 ms/op 21.272 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 10000 22.989 ms/op 23.349 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 300000 32.047 ms/op 31.678 ms/op 1.01
computeDeltas 3.2212 ms/op 3.3367 ms/op 0.97
computeProposerBoostScoreFromBalances 1.8216 ms/op 1.7788 ms/op 1.02
altair processAttestation - 250000 vs - 7PWei normalcase 3.1218 ms/op 2.1912 ms/op 1.42
altair processAttestation - 250000 vs - 7PWei worstcase 3.7767 ms/op 3.3322 ms/op 1.13
altair processAttestation - setStatus - 1/6 committees join 155.36 us/op 143.75 us/op 1.08
altair processAttestation - setStatus - 1/3 committees join 291.37 us/op 288.16 us/op 1.01
altair processAttestation - setStatus - 1/2 committees join 391.70 us/op 382.87 us/op 1.02
altair processAttestation - setStatus - 2/3 committees join 481.03 us/op 476.58 us/op 1.01
altair processAttestation - setStatus - 4/5 committees join 681.11 us/op 679.52 us/op 1.00
altair processAttestation - setStatus - 100% committees join 813.38 us/op 790.97 us/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase 20.489 ms/op 18.355 ms/op 1.12
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.972 ms/op 26.957 ms/op 1.15
altair processBlock - 250000 vs - 7PWei worstcase 61.083 ms/op 52.032 ms/op 1.17
altair processBlock - 250000 vs - 7PWei worstcase hashState 75.212 ms/op 67.317 ms/op 1.12
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8192 ms/op 2.2736 ms/op 1.24
phase0 processBlock - 250000 vs - 7PWei worstcase 34.975 ms/op 28.661 ms/op 1.22
altair processEth1Data - 250000 vs - 7PWei normalcase 577.84 us/op 471.81 us/op 1.22
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 10.644 us/op 7.3650 us/op 1.45
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 32.101 us/op 19.629 us/op 1.64
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 15.485 us/op 8.8440 us/op 1.75
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.4360 us/op 6.9910 us/op 1.35
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 121.96 us/op 85.323 us/op 1.43
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 689.51 us/op 645.22 us/op 1.07
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 928.87 us/op 929.65 us/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 910.97 us/op 910.50 us/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.5177 ms/op 2.4004 ms/op 1.05
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.7909 ms/op 1.5767 ms/op 1.14
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.7899 ms/op 3.8840 ms/op 1.23
Tree 40 250000 create 344.61 ms/op 301.94 ms/op 1.14
Tree 40 250000 get(125000) 197.58 ns/op 182.02 ns/op 1.09
Tree 40 250000 set(125000) 1.0470 us/op 962.36 ns/op 1.09
Tree 40 250000 toArray() 22.129 ms/op 18.200 ms/op 1.22
Tree 40 250000 iterate all - toArray() + loop 21.964 ms/op 17.551 ms/op 1.25
Tree 40 250000 iterate all - get(i) 78.517 ms/op 72.597 ms/op 1.08
MutableVector 250000 create 11.778 ms/op 13.013 ms/op 0.91
MutableVector 250000 get(125000) 7.2630 ns/op 6.3830 ns/op 1.14
MutableVector 250000 set(125000) 304.66 ns/op 266.43 ns/op 1.14
MutableVector 250000 toArray() 4.0714 ms/op 2.7215 ms/op 1.50
MutableVector 250000 iterate all - toArray() + loop 3.7621 ms/op 3.0107 ms/op 1.25
MutableVector 250000 iterate all - get(i) 1.5617 ms/op 1.5488 ms/op 1.01
Array 250000 create 2.9856 ms/op 2.5795 ms/op 1.16
Array 250000 clone - spread 1.1292 ms/op 1.3093 ms/op 0.86
Array 250000 get(125000) 0.56700 ns/op 0.65900 ns/op 0.86
Array 250000 set(125000) 0.64300 ns/op 0.74100 ns/op 0.87
Array 250000 iterate all - loop 86.097 us/op 112.38 us/op 0.77
effectiveBalanceIncrements clone Uint8Array 300000 41.021 us/op 32.577 us/op 1.26
effectiveBalanceIncrements clone MutableVector 300000 357.00 ns/op 433.00 ns/op 0.82
effectiveBalanceIncrements rw all Uint8Array 300000 180.06 us/op 170.49 us/op 1.06
effectiveBalanceIncrements rw all MutableVector 300000 90.211 ms/op 85.318 ms/op 1.06
phase0 afterProcessEpoch - 250000 vs - 7PWei 118.93 ms/op 113.89 ms/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 44.082 ms/op 34.495 ms/op 1.28
altair processEpoch - mainnet_e81889 361.10 ms/op 328.16 ms/op 1.10
mainnet_e81889 - altair beforeProcessEpoch 74.811 ms/op 70.828 ms/op 1.06
mainnet_e81889 - altair processJustificationAndFinalization 25.130 us/op 17.286 us/op 1.45
mainnet_e81889 - altair processInactivityUpdates 6.7793 ms/op 5.5243 ms/op 1.23
mainnet_e81889 - altair processRewardsAndPenalties 73.713 ms/op 66.588 ms/op 1.11
mainnet_e81889 - altair processRegistryUpdates 4.5430 us/op 2.3660 us/op 1.92
mainnet_e81889 - altair processSlashings 630.00 ns/op 453.00 ns/op 1.39
mainnet_e81889 - altair processEth1DataReset 691.00 ns/op 497.00 ns/op 1.39
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2917 ms/op 2.0455 ms/op 0.63
mainnet_e81889 - altair processSlashingsReset 5.4310 us/op 4.7100 us/op 1.15
mainnet_e81889 - altair processRandaoMixesReset 7.9960 us/op 4.3220 us/op 1.85
mainnet_e81889 - altair processHistoricalRootsUpdate 1.1970 us/op 777.00 ns/op 1.54
mainnet_e81889 - altair processParticipationFlagUpdates 4.7300 us/op 2.7410 us/op 1.73
mainnet_e81889 - altair processSyncCommitteeUpdates 1.0370 us/op 564.00 ns/op 1.84
mainnet_e81889 - altair afterProcessEpoch 131.48 ms/op 128.87 ms/op 1.02
phase0 processEpoch - mainnet_e58758 384.54 ms/op 361.67 ms/op 1.06
mainnet_e58758 - phase0 beforeProcessEpoch 154.35 ms/op 142.92 ms/op 1.08
mainnet_e58758 - phase0 processJustificationAndFinalization 24.759 us/op 17.221 us/op 1.44
mainnet_e58758 - phase0 processRewardsAndPenalties 67.712 ms/op 64.354 ms/op 1.05
mainnet_e58758 - phase0 processRegistryUpdates 10.778 us/op 9.2430 us/op 1.17
mainnet_e58758 - phase0 processSlashings 622.00 ns/op 505.00 ns/op 1.23
mainnet_e58758 - phase0 processEth1DataReset 1.0090 us/op 503.00 ns/op 2.01
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0293 ms/op 1.0817 ms/op 0.95
mainnet_e58758 - phase0 processSlashingsReset 4.4850 us/op 4.0030 us/op 1.12
mainnet_e58758 - phase0 processRandaoMixesReset 6.3010 us/op 4.8710 us/op 1.29
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0120 us/op 714.00 ns/op 1.42
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.2590 us/op 3.7550 us/op 1.67
mainnet_e58758 - phase0 afterProcessEpoch 104.38 ms/op 98.642 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3118 ms/op 1.2481 ms/op 1.05
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8399 ms/op 1.5487 ms/op 1.19
altair processInactivityUpdates - 250000 normalcase 28.822 ms/op 24.347 ms/op 1.18
altair processInactivityUpdates - 250000 worstcase 29.169 ms/op 27.526 ms/op 1.06
phase0 processRegistryUpdates - 250000 normalcase 10.296 us/op 7.1330 us/op 1.44
phase0 processRegistryUpdates - 250000 badcase_full_deposits 305.02 us/op 258.40 us/op 1.18
phase0 processRegistryUpdates - 250000 worstcase 0.5 130.81 ms/op 126.01 ms/op 1.04
altair processRewardsAndPenalties - 250000 normalcase 73.462 ms/op 66.102 ms/op 1.11
altair processRewardsAndPenalties - 250000 worstcase 73.531 ms/op 69.907 ms/op 1.05
phase0 getAttestationDeltas - 250000 normalcase 7.2829 ms/op 7.1279 ms/op 1.02
phase0 getAttestationDeltas - 250000 worstcase 7.2131 ms/op 7.1400 ms/op 1.01
phase0 processSlashings - 250000 worstcase 3.7211 ms/op 3.7850 ms/op 0.98
altair processSyncCommitteeUpdates - 250000 186.34 ms/op 182.23 ms/op 1.02
BeaconState.hashTreeRoot - No change 275.00 ns/op 266.00 ns/op 1.03
BeaconState.hashTreeRoot - 1 full validator 54.386 us/op 53.629 us/op 1.01
BeaconState.hashTreeRoot - 32 full validator 590.26 us/op 497.31 us/op 1.19
BeaconState.hashTreeRoot - 512 full validator 5.9301 ms/op 5.3350 ms/op 1.11
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 68.232 us/op 61.228 us/op 1.11
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0656 ms/op 881.47 us/op 1.21
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.785 ms/op 11.992 ms/op 1.15
BeaconState.hashTreeRoot - 1 balances 53.437 us/op 49.230 us/op 1.09
BeaconState.hashTreeRoot - 32 balances 479.10 us/op 461.34 us/op 1.04
BeaconState.hashTreeRoot - 512 balances 4.8351 ms/op 4.4921 ms/op 1.08
BeaconState.hashTreeRoot - 250000 balances 77.540 ms/op 77.120 ms/op 1.01
aggregationBits - 2048 els - zipIndexesInBitList 16.738 us/op 15.679 us/op 1.07
regular array get 100000 times 34.166 us/op 32.144 us/op 1.06
wrappedArray get 100000 times 34.029 us/op 42.839 us/op 0.79
arrayWithProxy get 100000 times 16.352 ms/op 14.476 ms/op 1.13
ssz.Root.equals 568.00 ns/op 527.00 ns/op 1.08
byteArrayEquals 549.00 ns/op 515.00 ns/op 1.07
shuffle list - 16384 els 7.1389 ms/op 6.6914 ms/op 1.07
shuffle list - 250000 els 103.44 ms/op 98.668 ms/op 1.05
processSlot - 1 slots 8.7610 us/op 9.0480 us/op 0.97
processSlot - 32 slots 1.3590 ms/op 1.3286 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.670 ms/op 37.088 ms/op 0.99
getCommitteeAssignments - req 1 vs - 250000 vc 2.9672 ms/op 2.9468 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.2183 ms/op 4.1744 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6004 ms/op 4.3827 ms/op 1.05
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.8800 ns/op 4.5200 ns/op 1.08
state getBlockRootAtSlot - 250000 vs - 7PWei 682.08 ns/op 929.67 ns/op 0.73
computeProposers - vc 250000 10.560 ms/op 11.431 ms/op 0.92
computeEpochShuffling - vc 250000 105.34 ms/op 104.79 ms/op 1.01
getNextSyncCommittee - vc 250000 182.36 ms/op 184.48 ms/op 0.99
computeSigningRoot for AttestationData 13.225 us/op 13.804 us/op 0.96
hash AttestationData serialized data then Buffer.toString(base64) 2.4891 us/op 2.5023 us/op 0.99
toHexString serialized data 1.0929 us/op 1.0849 us/op 1.01
Buffer.toString(base64) 330.63 ns/op 327.80 ns/op 1.01

by benchmarkbot/action

@twoeths
Copy link
Contributor

twoeths commented May 22, 2023

the upgrade looks good to me, can't review changes in every package but I trust @wemeetagain , dropped a comment
@wemeetagain I deployed this branch to feat2 mainnet node, will approve if metrics are comparable to unstable

@philknows philknows added this to the v1.10.0 milestone May 23, 2023
@twoeths
Copy link
Contributor

twoeths commented May 24, 2023

some issue I see after deploying this on a mainnet node:

  • cannot maintain consistent number of mesh peers like in unstable
  • send and receive too many goodbye requests
  • lodestar peer score is not as good as unstable
  • high Dial Error rate (which could lead to peer score issue above)
  • more disconnect - outbound rate

@philknows philknows added the prio-high Resolve issues as soon as possible. label Jun 13, 2023
@wemeetagain wemeetagain changed the title deps: update libp2p to 0.45.0 deps: update libp2p to 0.45.x Jun 13, 2023
@twoeths twoeths mentioned this pull request Jun 29, 2023
Merged
@wemeetagain
Copy link
Member Author

Latest metrics appear comparable to unstable, ready for re-review

@twoeths
Copy link
Contributor

twoeths commented Jul 5, 2023

metrics look great:

  • almost no dropped attestations in the last 6h (vs 60% on the mainnet node)
Screenshot 2023-07-05 at 08 28 00
  • almost 3x attestations were forwarded compared to stable (this is close to network thread config)
Screenshot 2023-07-05 at 08 29 04

  • time for block to become head, I/O lag is the same to stable

  • this could be because lower mesh peers compared to stable

Screenshot 2023-07-05 at 08 33 20

@twoeths twoeths merged commit 7280234 into unstable Jul 5, 2023
@twoeths twoeths deleted the cayman/update-libp2p branch July 5, 2023 01:37
@twoeths twoeths mentioned this pull request Jul 5, 2023
Closed
3 tasks
@nflaig
Copy link
Member

nflaig commented Jul 5, 2023

Getting a bunch of theses errors running unstable now

Jul-05 13:35:02.052[]                error: uncaughtException: Cannot read properties of undefined (reading '0')
TypeError: Cannot read properties of undefined (reading '0')
    at Libp2pNode.PeerDiscovery.onDiscoveredPeer (file:///home/devops/goerli/lodestar/packages/beacon-node/src/network/peers/discover.ts:276:60)
    at Libp2pNode.[nodejs.internal.kHybridDispatch] (node:internal/event_target:762:20)
    at Libp2pNode.dispatchEvent (node:internal/event_target:704:26)
    at Libp2pNode.dispatchEvent (file:///home/devops/goerli/lodestar/node_modules/@libp2p/interfaces/src/events.ts:64:26)
    at Libp2pNode.safeDispatchEvent (file:///home/devops/goerli/lodestar/node_modules/@libp2p/interfaces/src/events.ts:79:17)
    at EventEmitter.<anonymous> (file:///home/devops/goerli/lodestar/node_modules/libp2p/src/libp2p.ts:102:14)
    at EventEmitter.[nodejs.internal.kHybridDispatch] (node:internal/event_target:762:20)
    at EventEmitter.dispatchEvent (node:internal/event_target:704:26)
    at EventEmitter.dispatchEvent (file:///home/devops/goerli/lodestar/node_modules/@libp2p/interfaces/src/events.ts:64:26)
    at EventEmitter.Libp2pNode.events.dispatchEvent (file:///home/devops/goerli/lodestar/node_modules/libp2p/src/libp2p.ts:65:30) Cannot read properties of undefined (reading '0'

@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
prio-high Resolve issues as soon as possible.
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wemeetagain @twoeths @nflaig @philknows