Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename eip4844 fork as Deneb #5082

Merged
merged 6 commits into from
Jan 31, 2023
Merged

Rename eip4844 fork as Deneb #5082

merged 6 commits into from
Jan 31, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jan 30, 2023

Rename eip4844 fork as Deneb, ref:

Rename eip4844 fork to Deneb, there are two config references still unchanged:
EIP4844_FORK_EPOCH and EIP4844_FORK_VERSION which will be updated once new specs are released with the rename config params.

@g11tech g11tech requested a review from a team as a code owner January 30, 2023 18:35
@g11tech g11tech enabled auto-merge (squash) January 30, 2023 18:35
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 7dafe72 Previous: a0da8cd Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.0835 ms/op 1.0193 ms/op 1.06
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 62.664 us/op 59.638 us/op 1.05
BLS verify - blst-native 2.1768 ms/op 2.1726 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 4.4935 ms/op 4.4846 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 9.7223 ms/op 9.6970 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 35.358 ms/op 35.263 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 46.729 us/op 46.465 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 183.71 us/op 182.69 us/op 1.01
getAttestationsForBlock 81.469 ms/op 76.650 ms/op 1.06
isKnown best case - 1 super set check 440.00 ns/op 442.00 ns/op 1.00
isKnown normal case - 2 super set checks 430.00 ns/op 436.00 ns/op 0.99
isKnown worse case - 16 super set checks 429.00 ns/op 437.00 ns/op 0.98
CheckpointStateCache - add get delete 8.3760 us/op 8.3300 us/op 1.01
validate gossip signedAggregateAndProof - struct 5.0255 ms/op 5.0146 ms/op 1.00
validate gossip attestation - struct 2.3654 ms/op 2.3577 ms/op 1.00
pickEth1Vote - no votes 2.5098 ms/op 2.3391 ms/op 1.07
pickEth1Vote - max votes 17.075 ms/op 16.084 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.979 ms/op 13.422 ms/op 1.04
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.736 ms/op 20.784 ms/op 1.09
pickEth1Vote - Eth1Data fastSerialize value x2048 1.1321 ms/op 1.0789 ms/op 1.05
pickEth1Vote - Eth1Data fastSerialize tree x2048 10.781 ms/op 10.058 ms/op 1.07
bytes32 toHexString 958.00 ns/op 949.00 ns/op 1.01
bytes32 Buffer.toString(hex) 652.00 ns/op 631.00 ns/op 1.03
bytes32 Buffer.toString(hex) from Uint8Array 1.0310 us/op 991.00 ns/op 1.04
bytes32 Buffer.toString(hex) + 0x 675.00 ns/op 640.00 ns/op 1.05
Object access 1 prop 0.28700 ns/op 0.31900 ns/op 0.90
Map access 1 prop 0.29900 ns/op 0.34900 ns/op 0.86
Object get x1000 10.437 ns/op 10.741 ns/op 0.97
Map get x1000 0.98800 ns/op 0.97100 ns/op 1.02
Object set x1000 77.219 ns/op 69.164 ns/op 1.12
Map set x1000 47.235 ns/op 44.897 ns/op 1.05
Return object 10000 times 0.43890 ns/op 0.43660 ns/op 1.01
Throw Error 10000 times 6.7108 us/op 6.6761 us/op 1.01
fastMsgIdFn sha256 / 200 bytes 4.9190 us/op 4.9300 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 570.00 ns/op 522.00 ns/op 1.09
fastMsgIdFn h64 xxhash / 200 bytes 741.00 ns/op 693.00 ns/op 1.07
fastMsgIdFn sha256 / 1000 bytes 15.747 us/op 15.762 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 739.00 ns/op 689.00 ns/op 1.07
fastMsgIdFn h64 xxhash / 1000 bytes 844.00 ns/op 807.00 ns/op 1.05
fastMsgIdFn sha256 / 10000 bytes 136.32 us/op 137.93 us/op 0.99
fastMsgIdFn h32 xxhash / 10000 bytes 2.6800 us/op 2.5840 us/op 1.04
fastMsgIdFn h64 xxhash / 10000 bytes 1.8760 us/op 1.7820 us/op 1.05
enrSubnets - fastDeserialize 64 bits 2.6060 us/op 2.5050 us/op 1.04
enrSubnets - ssz BitVector 64 bits 1.0040 us/op 993.00 ns/op 1.01
enrSubnets - fastDeserialize 4 bits 359.00 ns/op 341.00 ns/op 1.05
enrSubnets - ssz BitVector 4 bits 1.0070 us/op 944.00 ns/op 1.07
prioritizePeers score -10:0 att 32-0.1 sync 2-0 147.68 us/op 151.31 us/op 0.98
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 167.16 us/op 168.40 us/op 0.99
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 249.93 us/op 247.59 us/op 1.01
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 441.37 us/op 421.41 us/op 1.05
prioritizePeers score 0:0 att 64-1 sync 4-1 503.29 us/op 488.35 us/op 1.03
array of 16000 items push then shift 51.634 us/op 51.602 us/op 1.00
LinkedList of 16000 items push then shift 12.780 ns/op 12.484 ns/op 1.02
array of 16000 items push then pop 183.85 ns/op 191.80 ns/op 0.96
LinkedList of 16000 items push then pop 12.433 ns/op 12.347 ns/op 1.01
array of 24000 items push then shift 77.400 us/op 77.381 us/op 1.00
LinkedList of 24000 items push then shift 13.210 ns/op 12.686 ns/op 1.04
array of 24000 items push then pop 196.02 ns/op 193.00 ns/op 1.02
LinkedList of 24000 items push then pop 12.406 ns/op 12.167 ns/op 1.02
intersect bitArray bitLen 8 21.690 ns/op 21.609 ns/op 1.00
intersect array and set length 8 133.82 ns/op 133.94 ns/op 1.00
intersect bitArray bitLen 128 69.971 ns/op 69.974 ns/op 1.00
intersect array and set length 128 1.7522 us/op 1.6776 us/op 1.04
Buffer.concat 32 items 5.2370 us/op 5.1780 us/op 1.01
Uint8Array.set 32 items 3.9550 us/op 3.9040 us/op 1.01
pass gossip attestations to forkchoice per slot 3.7829 ms/op 6.1644 ms/op 0.61
computeDeltas 4.3277 ms/op 4.5993 ms/op 0.94
computeProposerBoostScoreFromBalances 2.4972 ms/op 2.4967 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 3.8924 ms/op 3.3915 ms/op 1.15
altair processAttestation - 250000 vs - 7PWei worstcase 5.7961 ms/op 5.4346 ms/op 1.07
altair processAttestation - setStatus - 1/6 committees join 179.07 us/op 176.71 us/op 1.01
altair processAttestation - setStatus - 1/3 committees join 360.75 us/op 352.44 us/op 1.02
altair processAttestation - setStatus - 1/2 committees join 523.03 us/op 511.61 us/op 1.02
altair processAttestation - setStatus - 2/3 committees join 682.99 us/op 671.41 us/op 1.02
altair processAttestation - setStatus - 4/5 committees join 947.13 us/op 932.30 us/op 1.02
altair processAttestation - setStatus - 100% committees join 1.1315 ms/op 1.1156 ms/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 24.058 ms/op 25.747 ms/op 0.93
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.243 ms/op 33.687 ms/op 1.02
altair processBlock - 250000 vs - 7PWei worstcase 81.872 ms/op 86.561 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase hashState 102.65 ms/op 102.43 ms/op 1.00
phase0 processBlock - 250000 vs - 7PWei normalcase 3.4390 ms/op 3.4068 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 51.660 ms/op 51.284 ms/op 1.01
altair processEth1Data - 250000 vs - 7PWei normalcase 711.10 us/op 684.07 us/op 1.04
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.7710 us/op 8.6310 us/op 1.02
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 24.382 us/op 22.860 us/op 1.07
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 10.361 us/op 12.048 us/op 0.86
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 7.8370 us/op 10.434 us/op 0.75
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 96.556 us/op 93.044 us/op 1.04
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 889.59 us/op 890.39 us/op 1.00
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.1660 ms/op 1.2108 ms/op 0.96
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.1381 ms/op 1.1438 ms/op 1.00
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 4.2323 ms/op 4.2155 ms/op 1.00
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 2.3664 ms/op 2.7265 ms/op 0.87
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 7.7655 ms/op 7.0800 ms/op 1.10
Tree 40 250000 create 708.83 ms/op 633.57 ms/op 1.12
Tree 40 250000 get(125000) 292.43 ns/op 271.44 ns/op 1.08
Tree 40 250000 set(125000) 2.2773 us/op 1.9347 us/op 1.18
Tree 40 250000 toArray() 27.532 ms/op 25.755 ms/op 1.07
Tree 40 250000 iterate all - toArray() + loop 27.704 ms/op 26.738 ms/op 1.04
Tree 40 250000 iterate all - get(i) 104.92 ms/op 103.51 ms/op 1.01
MutableVector 250000 create 13.410 ms/op 13.147 ms/op 1.02
MutableVector 250000 get(125000) 11.956 ns/op 10.597 ns/op 1.13
MutableVector 250000 set(125000) 463.53 ns/op 489.12 ns/op 0.95
MutableVector 250000 toArray() 5.6597 ms/op 5.8668 ms/op 0.96
MutableVector 250000 iterate all - toArray() + loop 5.8698 ms/op 5.8740 ms/op 1.00
MutableVector 250000 iterate all - get(i) 2.6236 ms/op 2.6251 ms/op 1.00
Array 250000 create 5.6577 ms/op 6.0371 ms/op 0.94
Array 250000 clone - spread 2.0088 ms/op 1.9768 ms/op 1.02
Array 250000 get(125000) 0.98700 ns/op 1.0500 ns/op 0.94
Array 250000 set(125000) 0.98200 ns/op 1.0180 ns/op 0.96
Array 250000 iterate all - loop 150.90 us/op 151.58 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 44.340 us/op 34.788 us/op 1.27
effectiveBalanceIncrements clone MutableVector 300000 575.00 ns/op 607.00 ns/op 0.95
effectiveBalanceIncrements rw all Uint8Array 300000 243.88 us/op 243.76 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 148.53 ms/op 137.21 ms/op 1.08
phase0 afterProcessEpoch - 250000 vs - 7PWei 188.23 ms/op 187.19 ms/op 1.01
phase0 beforeProcessEpoch - 250000 vs - 7PWei 57.975 ms/op 56.842 ms/op 1.02
altair processEpoch - mainnet_e81889 477.94 ms/op 542.30 ms/op 0.88
mainnet_e81889 - altair beforeProcessEpoch 115.04 ms/op 76.479 ms/op 1.50
mainnet_e81889 - altair processJustificationAndFinalization 18.587 us/op 17.145 us/op 1.08
mainnet_e81889 - altair processInactivityUpdates 8.7024 ms/op 10.089 ms/op 0.86
mainnet_e81889 - altair processRewardsAndPenalties 78.485 ms/op 138.63 ms/op 0.57
mainnet_e81889 - altair processRegistryUpdates 2.6860 us/op 2.3000 us/op 1.17
mainnet_e81889 - altair processSlashings 514.00 ns/op 440.00 ns/op 1.17
mainnet_e81889 - altair processEth1DataReset 820.00 ns/op 567.00 ns/op 1.45
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9496 ms/op 2.3759 ms/op 0.82
mainnet_e81889 - altair processSlashingsReset 4.0900 us/op 3.5680 us/op 1.15
mainnet_e81889 - altair processRandaoMixesReset 4.1100 us/op 4.0100 us/op 1.02
mainnet_e81889 - altair processHistoricalRootsUpdate 919.00 ns/op 608.00 ns/op 1.51
mainnet_e81889 - altair processParticipationFlagUpdates 3.6330 us/op 2.1650 us/op 1.68
mainnet_e81889 - altair processSyncCommitteeUpdates 749.00 ns/op 514.00 ns/op 1.46
mainnet_e81889 - altair afterProcessEpoch 197.98 ms/op 195.90 ms/op 1.01
phase0 processEpoch - mainnet_e58758 488.66 ms/op 559.41 ms/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 185.49 ms/op 145.65 ms/op 1.27
mainnet_e58758 - phase0 processJustificationAndFinalization 18.214 us/op 17.604 us/op 1.03
mainnet_e58758 - phase0 processRewardsAndPenalties 72.922 ms/op 102.84 ms/op 0.71
mainnet_e58758 - phase0 processRegistryUpdates 8.9210 us/op 9.8480 us/op 0.91
mainnet_e58758 - phase0 processSlashings 739.00 ns/op 660.00 ns/op 1.12
mainnet_e58758 - phase0 processEth1DataReset 681.00 ns/op 694.00 ns/op 0.98
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6247 ms/op 2.2455 ms/op 0.72
mainnet_e58758 - phase0 processSlashingsReset 3.1970 us/op 3.5260 us/op 0.91
mainnet_e58758 - phase0 processRandaoMixesReset 4.2040 us/op 4.1640 us/op 1.01
mainnet_e58758 - phase0 processHistoricalRootsUpdate 875.00 ns/op 575.00 ns/op 1.52
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.9610 us/op 3.7710 us/op 1.58
mainnet_e58758 - phase0 afterProcessEpoch 163.77 ms/op 161.64 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9444 ms/op 1.9321 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.1955 ms/op 2.2088 ms/op 0.99
altair processInactivityUpdates - 250000 normalcase 31.755 ms/op 37.859 ms/op 0.84
altair processInactivityUpdates - 250000 worstcase 33.114 ms/op 38.859 ms/op 0.85
phase0 processRegistryUpdates - 250000 normalcase 8.3880 us/op 7.4620 us/op 1.12
phase0 processRegistryUpdates - 250000 badcase_full_deposits 378.26 us/op 391.84 us/op 0.97
phase0 processRegistryUpdates - 250000 worstcase 0.5 179.25 ms/op 180.21 ms/op 0.99
altair processRewardsAndPenalties - 250000 normalcase 74.098 ms/op 107.04 ms/op 0.69
altair processRewardsAndPenalties - 250000 worstcase 107.13 ms/op 75.287 ms/op 1.42
phase0 getAttestationDeltas - 250000 normalcase 12.087 ms/op 12.534 ms/op 0.96
phase0 getAttestationDeltas - 250000 worstcase 10.582 ms/op 12.713 ms/op 0.83
phase0 processSlashings - 250000 worstcase 5.5132 ms/op 5.2435 ms/op 1.05
altair processSyncCommitteeUpdates - 250000 295.26 ms/op 287.06 ms/op 1.03
BeaconState.hashTreeRoot - No change 520.00 ns/op 475.00 ns/op 1.09
BeaconState.hashTreeRoot - 1 full validator 72.947 us/op 73.566 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 743.64 us/op 702.15 us/op 1.06
BeaconState.hashTreeRoot - 512 full validator 7.3481 ms/op 6.9912 ms/op 1.05
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 89.141 us/op 102.38 us/op 0.87
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3292 ms/op 1.2892 ms/op 1.03
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.280 ms/op 17.160 ms/op 1.01
BeaconState.hashTreeRoot - 1 balances 69.211 us/op 68.050 us/op 1.02
BeaconState.hashTreeRoot - 32 balances 625.06 us/op 655.39 us/op 0.95
BeaconState.hashTreeRoot - 512 balances 6.4035 ms/op 6.2007 ms/op 1.03
BeaconState.hashTreeRoot - 250000 balances 112.59 ms/op 93.888 ms/op 1.20
aggregationBits - 2048 els - zipIndexesInBitList 25.007 us/op 25.864 us/op 0.97
regular array get 100000 times 60.524 us/op 60.603 us/op 1.00
wrappedArray get 100000 times 60.598 us/op 60.613 us/op 1.00
arrayWithProxy get 100000 times 26.824 ms/op 26.532 ms/op 1.01
ssz.Root.equals 975.00 ns/op 977.00 ns/op 1.00
byteArrayEquals 955.00 ns/op 981.00 ns/op 0.97
shuffle list - 16384 els 11.565 ms/op 11.417 ms/op 1.01
shuffle list - 250000 els 169.26 ms/op 166.35 ms/op 1.02
processSlot - 1 slots 13.198 us/op 13.207 us/op 1.00
processSlot - 32 slots 1.9708 ms/op 1.9414 ms/op 1.02
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 374.76 us/op 338.26 us/op 1.11
getCommitteeAssignments - req 1 vs - 250000 vc 5.4261 ms/op 5.4097 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 7.9531 ms/op 7.9762 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 8.4915 ms/op 8.5043 ms/op 1.00
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 8.5900 ns/op 8.0300 ns/op 1.07
state getBlockRootAtSlot - 250000 vs - 7PWei 1.4161 us/op 1.2861 us/op 1.10
computeProposers - vc 250000 17.699 ms/op 17.056 ms/op 1.04
computeEpochShuffling - vc 250000 172.33 ms/op 171.25 ms/op 1.01
getNextSyncCommittee - vc 250000 293.74 ms/op 285.64 ms/op 1.03

by benchmarkbot/action

@g11tech g11tech merged commit f19abf8 into unstable Jan 31, 2023
@g11tech g11tech deleted the g11tech/eip4844-to-deneb branch January 31, 2023 14:25
wemeetagain pushed a commit that referenced this pull request Feb 27, 2023
dapplion added a commit that referenced this pull request Feb 28, 2023
* v1.5.0

* Add validatior option to specify builder block selection strategy (#5064)

* Add validatior option to specify builder block selection strategy

* cleanup and improvements

* server api fx

* fix test

* fix the testcase

* Re-gossip bls changes if submitted earlier than capella (#5049)

* Cache and retransmit bls changes if submitted early

* regossip when synced on/post capella

* fix tests

* modify publish vs cache condition

* add logging

* add error logging

* batchify the processing

* fix some of the cases

* fix log issues

* also delete included keys

* fix lint

* simplify gossip loop

* fix build

* refac to a versioned bls change store

* update

* logging improvements

* improve logging and finish behavior

* cleanup

* Rename eip4844 fork as Deneb (#5082)

* Fix and extract payload to header conversion (#5101)

* Remove unused eslint disable directives (#5046)

* Add execution payload header to light client header capella onwards (#5027)

* Add execution payload header to light client header capella onwards

* add more forks

* add allfork types

* make other types multifork

* make events multifork compatible

* make lightclient routes multifork

* update light-client transport

* upgrade the blocktype on lightclient server import block

* fixes

* fix test

* fix event serialization/deserilization type

* update proof constants

* fix payload index

* update the light client update generation to multi fork

* fix types

* add spec override to pass specs

* make event types allforks

* make req/resp multifork

* make types multifork throughout

* fix the update serialize/deserialize

* fix error log

* better fork determination for update

* fix the fork of finalized

* fix tests

* fix header upgradation

* Fix zero finalized header in lightclient update gen (#5121)

* Schedule capella on sepolia (#5127)

* Get the capella builder functional (#5179)

* Allow blsChange reprocess/republish via API submission (#5185)

* Fix gossiping blsChange on submit if post capella

* comment improvement

* Use new db bucket for light client updates (#5205)

---------

Co-authored-by: Cayman <caymannava@gmail.com>
Co-authored-by: g11tech <develop@g11tech.io>
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants