-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set udp to enr #5001
Set udp to enr #5001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving pending testing. Thank you so much for the debugging effort @tuyennhv ❤️
Performance Report✔️ no performance regression detected Full benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metrics on this look really nice. 👍
Same work without setting maxConnection to tcp to verify the memory leak issue faster in nogroup 2 3
I recommend we do more experimentation in a future PR and merge this as-is
Motivation
Description
@chainsafe/snappy-stream
, migrated to 5.1.2maxConnection
(as ourmaxPeers
) to tcp helps, thanks @dapplionCloses #4623
TODOs
maxConnection
totcp
to verify the memory leak issue faster innogroup 2 3