-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use debug level when passing gossip attestations to forkchoice error #3671
Merged
twoeths
merged 1 commit into
master
from
tuyen/pass-gossip-attestations-to-forkchoice-log-error
Jan 28, 2022
Merged
Use debug level when passing gossip attestations to forkchoice error #3671
twoeths
merged 1 commit into
master
from
tuyen/pass-gossip-attestations-to-forkchoice-log-error
Jan 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoeths
requested review from
dapplion,
g11tech,
mpetrunic and
wemeetagain
as code owners
January 27, 2022 07:07
Code Climate has analyzed commit 98be032 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3671 +/- ##
=======================================
Coverage 37.13% 37.13%
=======================================
Files 321 321
Lines 8706 8706
Branches 1350 1350
=======================================
Hits 3233 3233
Misses 5330 5330
Partials 143 143 |
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
approved these changes
Jan 27, 2022
wemeetagain
approved these changes
Jan 27, 2022
twoeths
deleted the
tuyen/pass-gossip-attestations-to-forkchoice-log-error
branch
January 28, 2022 02:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When passing gossip attestations to forkchoice and there are error, it does not affect the functionality while it's logged as
logger.error
, switch to usinglogger.debug()
so that we can investigate further if neededDescription
Closes #3665