-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weak subjecitivity checks #3391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit f068176 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3391 +/- ##
=======================================
Coverage 38.36% 38.36%
=======================================
Files 303 303
Lines 7738 7738
Branches 1157 1157
=======================================
Hits 2969 2969
Misses 4628 4628
Partials 141 141 |
g11tech
force-pushed
the
wssyncchecks
branch
3 times, most recently
from
October 26, 2021 07:24
5f0ca18
to
57af146
Compare
dapplion
previously requested changes
Oct 28, 2021
g11tech
requested review from
mpetrunic,
twoeths and
wemeetagain
as code owners
October 31, 2021 08:49
dapplion
reviewed
Oct 31, 2021
wemeetagain
reviewed
Nov 2, 2021
wemeetagain
previously approved these changes
Nov 2, 2021
twoeths
previously approved these changes
Nov 3, 2021
wemeetagain
approved these changes
Nov 3, 2021
dapplion
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The aim of the PR is to rectify weak subjectivity checks:
Description
UPDATE:
previous resolution of making the wss check on the head when chain syncs to synced state for the first time was deemed overkill, so reverted that and replaced with the initialization time
clockEpoch
check.example error of providing an checkpoint wss subjectivity period behind the
clockEpoch
Closes #issue_number
partially closes #3385
Steps to test or reproduce