Add Altair VC client #2520
Add Altair VC client #2520
Conversation
|
Code Climate has analyzed commit e041e3c and detected 22 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This pull request introduces 5 alerts when merging 117f77b into 7650671 - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging 2607886 into 7650671 - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging cd11799 into 7579f7f - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging e796e12 into 7579f7f - view on LGTM.com new alerts:
|
| // Produce one attestation data per slot and subcommitteeIndex | ||
| // Spec: the validator should prepare a SyncCommitteeSignature for the previous slot (slot - 1) | ||
| // as soon as they have determined the head block of slot - 1 | ||
| const beaconBlockRoot = await this.apiClient.beacon.blocks.getBlockRoot(slot - 1).catch((e) => { |
There was a problem hiding this comment.
my understanding is we want to get block root at the current slot since we wait for 1/3 slot already, so getBlockRoot(slot)
correct me if I'm wrong
There was a problem hiding this comment.
will address in future PRs
There was a problem hiding this comment.
Yeah that's right, we want to sign the head at that slot since the signatures will be included in the next. Even we can / should do getBlockRoot("head")
There was a problem hiding this comment.
See #2522 as conclusion
Motivation
Completes the work started with #2514. Part of #2388
Description
SyncCommitteeService+SyncCommitteeDutiesServicewhich work very similar to the attester services.IndicesServiceused by sync and att services