Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gossipFactor parameter to GossipsubOpts #502

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

mkermani144
Copy link
Contributor

Closes #501

Based on the spec, `GossipFactor` is a parameter other than a constant,
and can be configured.
@mkermani144 mkermani144 requested a review from a team as a code owner August 17, 2024 11:48
wemeetagain
wemeetagain previously approved these changes Aug 17, 2024
@wemeetagain wemeetagain changed the title fix: add missing GossipFactor parameter to GossipsubOpts feat: add gossipFactor parameter to GossipsubOpts Aug 17, 2024
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkermani144

@wemeetagain wemeetagain merged commit 07b995c into ChainSafe:master Aug 19, 2024
9 checks passed
@mkermani144 mkermani144 deleted the fix/gossip-factor-config branch August 19, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GossipFactor is not configurable
3 participants