chore(dot/sync): handleJustification returns errors
#2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
from
75b66e8 to
9ff513c
Compare
qdm12
force-pushed
the
qdm12/genesis/less-dependencies
branch
from
d5eed9a to
95ba320
Compare
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
from
9ff513c to
95ba320
Compare
qdm12
commented
Sep 12, 2022
| if len(justification) == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I don't think that can ever happen really, but keeping it to be safe ™️
qdm12
force-pushed
the
qdm12/genesis/less-dependencies
branch
2 times, most recently
from
f155179 to
edd1f99
Compare
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
from
ceb798e to
1d661d6
Compare
qdm12
force-pushed
the
qdm12/genesis/less-dependencies
branch
2 times, most recently
from
357cabe to
6b0f0eb
Compare
Base automatically changed from
qdm12/genesis/less-dependencies
to
development
September 20, 2022 15:14
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
from
1d661d6 to
793bebc
Compare
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Sep 20, 2022
noot
approved these changes
Sep 22, 2022
qdm12
force-pushed
the
qdm12/dot/sync/handle-just
branch
from
793bebc to
7707152
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer/dot/sync/...Issues
Primary Reviewer
@noot