task(lib/grandpa): ensure messages are stored and re-processed when needed

[kishansagathiya]

Changes

• We are storing grandpa notification messages in cache to make sure that we send them only one. If the message was a consensus messages, we were sending it even if it was already sent.
• With this PR, we will not be sending consensus messages again, if they were already sent. The receiver keeps track of received messages that they could not process, so that they can be processed in future. (check usage of addVote for more context)

Tests

• check that tests for dot/network and lib/grandpa passes and so does other relevant tests
• run grandpa rounds, check that we don't see votes that we already have

Issues

• lib/grandpa: ensure messages are stored and re-processed when needed #1855

Primary Reviewer

• @noot

[codecov]

Codecov Report

Merging #2107 (2ae41d4) into development (ccf12de) will increase coverage by 0.00%.
The diff coverage is 63.41%.

@@             Coverage Diff              @@
##           development    #2107   +/-   ##
============================================
  Coverage        61.56%   61.57%           
============================================
  Files              213      213           
  Lines            27448    27461   +13     
============================================
+ Hits             16898    16908   +10     
- Misses            8683     8684    +1     
- Partials          1867     1869    +2     

Flag	Coverage Δ
unit-tests	61.57% <63.41%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/grandpa/message_handler.go	63.50% <30.00%> (-0.93%)	⬇️
dot/network/notifications.go	64.50% <50.00%> (-0.13%)	⬇️
lib/grandpa/message_tracker.go	66.15% <69.23%> (-4.34%)	⬇️
lib/grandpa/grandpa.go	59.05% <100.00%> (+0.21%)	⬆️
lib/grandpa/network.go	47.40% <100.00%> (+0.64%)	⬆️
lib/grandpa/vote_message.go	81.96% <100.00%> (ø)
dot/network/message_cache.go	58.33% <0.00%> (-8.34%)	⬇️
dot/network/light.go	85.25% <0.00%> (-0.80%)	⬇️
lib/runtime/wasmer/imports.go	48.71% <0.00%> (+0.05%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c964e...2ae41d4. Read the comment docs.

[qdm12]

There are still a few comments / TODOs I'm not sure how to address, let's see what others have to say 😉

[noot]

maybe update the warn log? :p

[kishansagathiya]

not sure what you want here? Add this comment in log or remove the log?

[noot]

looks good, going to try this on the devnet to make sure there's no regressions, then i will approve :p

[EclesioMeloJunior]

@noot @kishansagathiya should we add in the MessageHandler.handleCatchUpResponse a code (if the handle was successful) to check if the given message was stored in the tracker and then remove it?

[EclesioMeloJunior]

LGTM