chore(tests): cache runtimes to work offline (#2577)

- Download runtimes to ${TMP}/gossamer/runtimes/ depending on environment
- Do not remove runtime files and re-use them if found
- Merge `GetRuntimeVars` and `GetRuntimeBlob` into `GetRuntime`
- Improve HTTP fetching code for runtime wasms
- Remove `TestMain`-used `GetRuntimes` since we already have calls to `GetRuntime` wherever a runtime blob is needed.

cmd/gossamer/config_test.go

@@ -4,6 +4,7 @@
 package main
 
 import (
+	"context"
 	"encoding/hex"
 	"encoding/json"
 	"errors"
@@ -941,9 +942,7 @@ func TestGlobalNodeName_WhenNodeAlreadyHasStoredName(t *testing.T) {
 	cfg := newTestConfig(t)
 	cfg.Global.Name = globalName
 
-	runtimeFilePath := filepath.Join(t.TempDir(), "runtime")
-	_, testRuntimeURL := runtime.GetRuntimeVars(runtime.NODE_RUNTIME)
-	err := runtime.GetRuntimeBlob(runtimeFilePath, testRuntimeURL)
+	runtimeFilePath, err := runtime.GetRuntime(context.Background(), runtime.NODE_RUNTIME)
 	require.NoError(t, err)
 	runtimeData, err := os.ReadFile(runtimeFilePath)
 	require.NoError(t, err)

dot/core/service_integration_test.go

@@ -6,6 +6,7 @@
 package core
 
 import (
+	"context"
 	"fmt"
 	"math/big"
 	"os"
@@ -134,20 +135,6 @@ func generateTestValidRemarkTxns(t *testing.T, pubKey []byte, accInfo types.Acco
 	return extBytes, rt
 }
 
-func TestMain(m *testing.M) {
-	wasmFilePaths, err := runtime.GenerateRuntimeWasmFile()
-	if err != nil {
-		log.Errorf("failed to generate runtime wasm file: %s", err)
-		os.Exit(1)
-	}
-
-	// Start all tests
-	code := m.Run()
-
-	runtime.RemoveFiles(wasmFilePaths)
-	os.Exit(code)
-}
-
 func TestStartService(t *testing.T) {
 	s := NewTestService(t, nil)
 
@@ -695,7 +682,9 @@ func TestService_HandleRuntimeChanges(t *testing.T) {
 func TestService_HandleCodeSubstitutes(t *testing.T) {
 	s := NewTestService(t, nil)
 
-	testRuntime, err := os.ReadFile(runtime.POLKADOT_RUNTIME_FP)
+	runtimeFilepath, err := runtime.GetRuntime(context.Background(), runtime.POLKADOT_RUNTIME)
+	require.NoError(t, err)
+	testRuntime, err := os.ReadFile(runtimeFilepath)
 	require.NoError(t, err)
 
 	// hash for known test code substitution
@@ -745,7 +734,9 @@ func TestService_HandleRuntimeChangesAfterCodeSubstitutes(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, codeHashBefore, parentRt.GetCodeHash()) // codeHash should remain unchanged after code substitute
 
-	testRuntime, err := os.ReadFile(runtime.POLKADOT_RUNTIME_FP)
+	runtimeFilepath, err := runtime.GetRuntime(context.Background(), runtime.POLKADOT_RUNTIME)
+	require.NoError(t, err)
+	testRuntime, err := os.ReadFile(runtimeFilepath)
 	require.NoError(t, err)
 
 	ts, err = s.storageState.TrieState(nil)

dot/node_integration_test.go

@@ -6,6 +6,7 @@
 package dot
 
 import (
+	"context"
 	"encoding/hex"
 	"encoding/json"
 	"os"
@@ -271,9 +272,7 @@ func TestNode_PersistGlobalName_WhenInitialize(t *testing.T) {
 // newTestGenesisAndRuntime create a new test runtime and a new test genesis
 // file with the test runtime stored in raw data and returns the genesis file
 func newTestGenesisAndRuntime(t *testing.T) (filename string) {
-	runtimeFilePath := filepath.Join(t.TempDir(), "runtime")
-	_, testRuntimeURL := runtime.GetRuntimeVars(runtime.NODE_RUNTIME)
-	err := runtime.GetRuntimeBlob(runtimeFilePath, testRuntimeURL)
+	runtimeFilePath, err := runtime.GetRuntime(context.Background(), runtime.NODE_RUNTIME)
 	require.NoError(t, err)
 	runtimeData, err := os.ReadFile(runtimeFilePath)
 	require.NoError(t, err)

dot/rpc/modules/author_integration_test.go

@@ -6,6 +6,7 @@
 package modules
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"os"
@@ -53,16 +54,11 @@ func useInstanceFromGenesis(t *testing.T, rtStorage *storage.TrieState) (instanc
 }
 
 func useInstanceFromRuntimeV0910(t *testing.T, rtStorage *storage.TrieState) (instance runtime.Instance) {
-	testRuntimeFilePath, testRuntimeURL := runtime.GetRuntimeVars(runtime.POLKADOT_RUNTIME_v0910)
-	err := runtime.GetRuntimeBlob(testRuntimeFilePath, testRuntimeURL)
+	testRuntimeFilePath, err := runtime.GetRuntime(context.Background(), runtime.POLKADOT_RUNTIME_v0910)
 	require.NoError(t, err)
-
 	bytes, err := os.ReadFile(testRuntimeFilePath)
 	require.NoError(t, err)
 
-	err = runtime.RemoveFiles([]string{testRuntimeFilePath})
-	require.NoError(t, err)
-
 	rtStorage.Set(common.CodeKey, bytes)
 
 	cfg := &wasmer.Config{}
@@ -82,20 +78,6 @@ func useInstanceFromRuntimeV0910(t *testing.T, rtStorage *storage.TrieState) (in
 	return runtimeInstance
 }
 
-func TestMain(m *testing.M) {
-	wasmFilePaths, err := runtime.GenerateRuntimeWasmFile()
-	if err != nil {
-		log.Errorf("failed to generate runtime wasm file: %s", err)
-		os.Exit(1)
-	}
-
-	// Start all tests
-	code := m.Run()
-
-	runtime.RemoveFiles(wasmFilePaths)
-	os.Exit(code)
-}
-
 func TestAuthorModule_Pending_Integration(t *testing.T) {
 	t.Parallel()
 	integrationTestController := setupStateAndRuntime(t, t.TempDir(), nil)

dot/rpc/subscription/listeners_test.go

@@ -4,13 +4,13 @@
 package subscription
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"log"
 	"net/http"
 	"net/http/httptest"
 	"os"
-	"path/filepath"
 	"strings"
 	"testing"
 	"time"
@@ -352,11 +352,9 @@ func TestRuntimeChannelListener_Listen(t *testing.T) {
 	expectedInitialResponse.Params.Result = expectedInitialVersion
 
 	instance := wasmer.NewTestInstance(t, runtime.NODE_RUNTIME)
-	err := runtime.GetRuntimeBlob(runtime.POLKADOT_RUNTIME_FP, runtime.POLKADOT_RUNTIME_URL)
+	polkadotRuntimeFilepath, err := runtime.GetRuntime(context.Background(), runtime.POLKADOT_RUNTIME)
 	require.NoError(t, err)
-	fp, err := filepath.Abs(runtime.POLKADOT_RUNTIME_FP)
-	require.NoError(t, err)
-	code, err := os.ReadFile(fp)
+	code, err := os.ReadFile(polkadotRuntimeFilepath)
 	require.NoError(t, err)
 	version, err := instance.CheckRuntimeVersion(code)
 	require.NoError(t, err)

dot/sync/syncer_integeration_test.go

@@ -8,7 +8,6 @@ package sync
 
 import (
 	"errors"
-	"os"
 	"path/filepath"
 	"testing"
 
@@ -28,20 +27,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestMain(m *testing.M) {
-	wasmFilePaths, err := runtime.GenerateRuntimeWasmFile()
-	if err != nil {
-		log.Errorf("failed to generate runtime wasm file: %s", err)
-		os.Exit(1)
-	}
-
-	// Start all tests
-	code := m.Run()
-
-	runtime.RemoveFiles(wasmFilePaths)
-	os.Exit(code)
-}
-
 func newMockFinalityGadget() *mocks.FinalityGadget {
 	m := new(mocks.FinalityGadget)
 	// using []uint8 instead of []byte: https://github.com/stretchr/testify/pull/969

lib/babe/babe_integration_test.go

@@ -6,7 +6,6 @@
 package babe
 
 import (
-	"os"
 	"path/filepath"
 	"testing"
 	"time"
@@ -153,22 +152,6 @@ func createTestService(t *testing.T, cfg *ServiceConfig) *Service {
 	return babeService
 }
 
-func TestMain(m *testing.M) {
-	wasmFilePaths, err := runtime.GenerateRuntimeWasmFile()
-	if err != nil {
-		log.Errorf("failed to generate runtime wasm file: %s", err)
-		os.Exit(1)
-	}
-
-	logger = log.NewFromGlobal(log.SetLevel(defaultTestLogLvl))
-
-	// Start all tests
-	code := m.Run()
-
-	runtime.RemoveFiles(wasmFilePaths)
-	os.Exit(code)
-}
-
 func newTestServiceSetupParameters(t *testing.T) (*Service, *state.EpochState, *types.BabeConfiguration) {
 	ctrl := gomock.NewController(t)
 	telemetryMock := NewMockClient(ctrl)

lib/runtime/constants.go

@@ -7,8 +7,6 @@ import (
 	"github.com/ChainSafe/gossamer/lib/common"
 )
 
-var runtimes = []string{HOST_API_TEST_RUNTIME, POLKADOT_RUNTIME, POLKADOT_RUNTIME_v0917, NODE_RUNTIME, DEV_RUNTIME}
-
 //nolint:revive
 const (
 	// v0.9 substrate runtime

lib/runtime/life/test_helpers.go

@@ -4,7 +4,7 @@
 package life
 
 import (
-	"path/filepath"
+	"context"
 	"testing"
 
 	"github.com/ChainSafe/gossamer/internal/log"
@@ -20,30 +20,24 @@ var DefaultTestLogLvl = log.Info
 
 // newTestInstance will create a new runtime instance using the given target runtime
 func newTestInstance(t *testing.T, targetRuntime string) *Instance {
-	return newTestInstanceWithTrie(t, runtime.HOST_API_TEST_RUNTIME, nil, DefaultTestLogLvl)
+	return newTestInstanceWithTrie(t, targetRuntime, nil, DefaultTestLogLvl)
 }
 
 // newTestInstanceWithTrie will create a new runtime instance with the supplied trie as the storage
 func newTestInstanceWithTrie(t *testing.T, targetRuntime string, tt *trie.Trie, lvl log.Level) *Instance {
-	fp, cfg := setupConfig(t, targetRuntime, tt, lvl, 0)
-	r, err := NewInstanceFromFile(fp, cfg)
+	testRuntimeFilePath, err := runtime.GetRuntime(context.Background(), targetRuntime)
+	require.NoError(t, err)
+	cfg := setupConfig(t, tt, lvl, 0)
+	r, err := NewInstanceFromFile(testRuntimeFilePath, cfg)
 	require.NoError(t, err, "Got error when trying to create new VM", "targetRuntime", targetRuntime)
 	require.NotNil(t, r, "Could not create new VM instance", "targetRuntime", targetRuntime)
 	return r
 }
 
-func setupConfig(t *testing.T, targetRuntime string, tt *trie.Trie, lvl log.Level, role byte) (string, *Config) {
-	testRuntimeFilePath, testRuntimeURL := runtime.GetRuntimeVars(targetRuntime)
-
-	err := runtime.GetRuntimeBlob(testRuntimeFilePath, testRuntimeURL)
-	require.Nil(t, err, "Fail: could not get runtime", "targetRuntime", targetRuntime)
-
+func setupConfig(t *testing.T, tt *trie.Trie, lvl log.Level, role byte) *Config {
 	s, err := storage.NewTrieState(tt)
 	require.NoError(t, err)
 
-	fp, err := filepath.Abs(testRuntimeFilePath)
-	require.Nil(t, err, "could not create testRuntimeFilePath", "targetRuntime", targetRuntime)
-
 	ns := runtime.NodeStorage{
 		LocalStorage:      runtime.NewInMemoryDB(t),
 		PersistentStorage: runtime.NewInMemoryDB(t), // we're using a local storage here since this is a test runtime
@@ -56,5 +50,5 @@ func setupConfig(t *testing.T, targetRuntime string, tt *trie.Trie, lvl log.Leve
 	cfg.Network = new(runtime.TestRuntimeNetwork)
 	cfg.Role = role
 	cfg.Resolver = new(Resolver)
-	return fp, cfg
+	return cfg
 }