-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor discovery, improve Hello handling/peer management #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
added
Type: Enhancement
Status: Needs Review
Network
Libp2p and PubSub stuff
labels
Jan 30, 2021
ec2
reviewed
Feb 1, 2021
Output = ( | ||
PeerId, | ||
SystemTime, | ||
Option<Result<HelloResponse, RequestResponseError>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I normally really like rustfmt... This is one of the rare cases lol
ec2
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Refactors discovery into it's own behaviour and improves interactions
Handle hello responses as well as correctly logging failure and marking peers as bad on libp2p errors such as unsupported protocols or dial failures
How the hello responses are handled is when a hello request is sent, a boxed future is returned. This future is added to a FuturesUnordered and polled in the chain syncer.
Reference issue to close (if applicable)
Closes #966
Other information and links