Rename BlockSync -> ChainExchange and tweak parameters #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ansermino,
dutterbutter and
ec2
as code owners
austinabell
changed the title
dutterbutter
approved these changes
Nov 16, 2020
ec2
reviewed
Nov 16, 2020
| yamux_config.set_max_buffer_size(1 << 20); | ||
| yamux_config.set_receive_window(1 << 20); | ||
| yamux_config.set_max_buffer_size(16 * 1024 * 1024); | ||
| yamux_config.set_receive_window(16 * 1024 * 1024); |
There was a problem hiding this comment.
Can you explain a little how these parameters are decided on? You said in the PR description the window size is now large enough, but 1 << 20 is larger than 16 * 1024 * 1024...
There was a problem hiding this comment.
nah it isn't (16_777_216 > 1_048_576) I updated the window size to be equal to the default go one, just to make sure no issues. 1<<20 was an arbitrary number I didn't think we would hit lol.
2^4*2^10*2^10 > 2^20 (16x larger)
There was a problem hiding this comment.
oh shoot, youre right.... throws out my math degree
There was a problem hiding this comment.
It looks smaller though, right?
ec2
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Other information and links